Don't worry, it wasn't a problem. All the tests of the test suite passed on my machine so the changes didn't break anything. It would be useful to do a few profiling tests to see if there are any speed ups, not that that matters, and then to merge these changes (back) into the main 1.3 line. I might try a bit of profiling on the weekend.
Edward On 10/23/06, Chris MacRaild <[EMAIL PROTECTED]> wrote:
Opps. Not sure how I managed to do that. What you get for rushing these last thing on a Friday afternoon I guess... r2662 and 2663 fix things, I hope. The test suite gives identical results for both versions of code, but I've not yet done any profiling or performance tests. Chris On Sat, 2006-10-21 at 02:02 +1000, Edward d'Auvergne wrote: > Chris, I think you may have accidentally modified the wrong copy of > the code? Is the test suite happy? Do you think it's worth doing a > bit of profiling to see if relax is now faster and, if so, by how > much? > > Edward > > > On 10/21/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Author: macraild > > Date: Fri Oct 20 17:21:10 2006 > > New Revision: 2657 > > > > URL: http://svn.gna.org/viewcvs/relax?rev=2657&view=rev > > Log: > > Removal of apply(func, args) calls from the minimisation code > > > > As discussed at relax-devel: > > https://mail.gna.org/public/relax-devel/2006-10/msg00103.html > > > > > > Modified: > > 1.3/minimise/base_classes.py > > 1.3/minimise/bfgs.py > > 1.3/minimise/cauchy_point.py > > 1.3/minimise/coordinate_descent.py > > 1.3/minimise/dogleg.py > > 1.3/minimise/exact_trust_region.py > > 1.3/minimise/fletcher_reeves_cg.py > > 1.3/minimise/grid.py > > 1.3/minimise/hestenes_stiefel_cg.py > > 1.3/minimise/levenberg_marquardt.py > > 1.3/minimise/line_search/backtrack.py > > 1.3/minimise/line_search/more_thuente.py > > 1.3/minimise/line_search/nocedal_wright_interpol.py > > 1.3/minimise/line_search/nocedal_wright_wolfe.py > > 1.3/minimise/line_search/test_functions.py > > 1.3/minimise/method_of_multipliers.py > > 1.3/minimise/ncg.py > > 1.3/minimise/newton.py > > 1.3/minimise/polak_ribiere_cg.py > > 1.3/minimise/polak_ribiere_plus_cg.py > > 1.3/minimise/simplex.py > > 1.3/minimise/steepest_descent.py > > 1.3/minimise/steihaug_cg.py > > > > [This mail would be too long, it was shortened to contain the URLs only.] > > > > Modified: 1.3/minimise/base_classes.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/base_classes.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/bfgs.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/bfgs.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/cauchy_point.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/cauchy_point.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/coordinate_descent.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/coordinate_descent.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/dogleg.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/dogleg.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/exact_trust_region.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/exact_trust_region.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/fletcher_reeves_cg.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/fletcher_reeves_cg.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/grid.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/grid.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/hestenes_stiefel_cg.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/hestenes_stiefel_cg.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/levenberg_marquardt.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/levenberg_marquardt.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/line_search/backtrack.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/line_search/backtrack.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/line_search/more_thuente.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/line_search/more_thuente.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/line_search/nocedal_wright_interpol.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/line_search/nocedal_wright_interpol.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/line_search/nocedal_wright_wolfe.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/line_search/nocedal_wright_wolfe.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/line_search/test_functions.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/line_search/test_functions.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/method_of_multipliers.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/method_of_multipliers.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/ncg.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/ncg.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/newton.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/newton.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/polak_ribiere_cg.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/polak_ribiere_cg.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/polak_ribiere_plus_cg.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/polak_ribiere_plus_cg.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/simplex.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/simplex.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/steepest_descent.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/steepest_descent.py?rev=2657&r1=2656&r2=2657&view=diff > > > > Modified: 1.3/minimise/steihaug_cg.py > > URL: http://svn.gna.org/viewcvs/relax/1.3/minimise/steihaug_cg.py?rev=2657&r1=2656&r2=2657&view=diff > > > > > > _______________________________________________ > > relax (http://nmr-relax.com) > > > > This is the relax-commits mailing list > > [email protected] > > > > To unsubscribe from this list, get a password > > reminder, or change your subscription options, > > visit the list information page at > > https://mail.gna.org/listinfo/relax-commits > > >
_______________________________________________ relax (http://nmr-relax.com) This is the relax-devel mailing list [email protected] To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
