Hi, Ok, I'll go through this patch bit by bit. I can apply one patch with all changes but, if it introduces bug, then the whole lot must go! You will then have to salvage the patch somehow. This might be more of an issue for the dauvergne_protocol code than for the NOE analysis. I will also need a commit message from you detailing all these unrelated changes. Firstly, sorry, I didn't notice that the mc_num arg is not actually used - that deletion is fine. Only 2 things remain:
1) The "@type seq_args" epydoc documentation is missing and will break the API documentation system. 2) See my previous email about the heteronuc_pdb arg. The rest is perfectly fine! The patch applies cleanly. So there is not much to change here. Sorry again for all the problems this is causing, but we just need to be careful not to introduce bugs or restrictions for relax users. Cheers, Edward On 31 May 2010 03:18, Michael Bieri <[email protected]> wrote: > > Follow-up Comment #53, task #6847 (project relax): > > Hi Edward > > I applied your suggestions for the noe.py script. But I will send them as one > patch. I realy would like to pursuit as I will be in holuday the next 2 > weeks. > > Short comments to your comments on the noe.py script > (https://mail.gna.org/public/relax-devel/2010-05/msg00006.html): > > I renamed filename to output_file. > > The argument mc_num is deleted, as it is not used in this script. > > The '@keyword heteronuc:' epydoc is added. > > I added another argument: neteronuc_pdb. This is to define the name of the > heteronucleus in the pbd file. This is also used in reading the sequence from > the pdb file. > > I hope that's about it. > > If you are fine with these changes, I will modify them in the other scripts > as well. > > Cheers > Michael > > > > > (file #9222) > _______________________________________________________ > > Additional Item Attachment: > > File name: patch Size:7 KB > > > _______________________________________________________ > > Reply to this item at: > > <http://gna.org/task/?6847> > > _______________________________________________ > Message sent via/by Gna! > http://gna.org/ > > > _______________________________________________ > relax (http://nmr-relax.com) > > This is the relax-devel mailing list > [email protected] > > To unsubscribe from this list, get a password > reminder, or change your subscription options, > visit the list information page at > https://mail.gna.org/listinfo/relax-devel > _______________________________________________ relax (http://nmr-relax.com) This is the relax-devel mailing list [email protected] To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
