Hi,
That was nicely done with the commit message and change! I only had
to modify the last sentence so that it was max 100 characters wide
(easy to do in vi). I would make one recommendation, and that is the
option parser='internal' to the structure.read_xyz() user function
could be deleted. This is only used in the structure.read_pdb()
function to choose between the parser I wrote myself ('internal') or
the Scientific Python parser ('scientific', see
http://dirac.cnrs-orleans.fr/plone/software/scientificpython/).
Cheers,
Edward
On 9 June 2011 19:12, Han Sun <[email protected]> wrote:
> The commit message:
>
> Changed paths:
> M /branches/xyz/test_suite/system_tests/structure.py
>
> Modifying the function test 'test_read_xyz_internal1()'.
>
> This is Han's patch https://gna.org/task/download.php?file_id=13144 attached
> to the task
> http://gna.org/task/?7404.
>
> The function 'test_read_xyz_internal1()' was modified so that it is more
> specific to the XYZ file added to relax and for the new XYZ reader.
>
>
>
>
> On Jun 9, 2011, at 7:07 PM, Han Sun wrote:
>
>>
>> Additional Item Attachment, task #7404 (project relax):
>>
>> File name: patch Size:1 KB
>>
>>
>> _______________________________________________________
>>
>> Reply to this item at:
>>
>> <http://gna.org/task/?7404>
>>
>> _______________________________________________
>> Message sent via/by Gna!
>> http://gna.org/
>>
>
>
> _______________________________________________
> relax (http://nmr-relax.com)
>
> This is the relax-devel mailing list
> [email protected]
>
> To unsubscribe from this list, get a password
> reminder, or change your subscription options,
> visit the list information page at
> https://mail.gna.org/listinfo/relax-devel
>
_______________________________________________
relax (http://nmr-relax.com)
This is the relax-devel mailing list
[email protected]
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel
