Hi Troels, In the situation where you have a fix for a bug, I would recommend the following procedure:
1) First create a bug report describing the problem from the point of view of a user. This is important as the bug report system is used by relax users to determine if the problem they are seeing has already been reported. 2) Attach the patch file and give the text formatted for a commit message. This is described at http://www.nmr-relax.com/manual/Format_commit_logs.html. A recent example is http://svn.gna.org/viewcvs/relax?view=revision&revision=20176. I should be able to copy and paste that text without modification for the commit. 3) Wait for me to apply the commit or to suggest how the patch should be improved. Cheers, Edward P. S. In this case, the line you commented out should instead be deleted. I like the use of the isfile() function, this is a much better approach! Could you attach a new patch with the commit message to use, including the links to the bug report. Thanks. On 17 June 2013 16:47, Troels E. Linnet <[email protected]> wrote: > URL: > <http://gna.org/bugs/?20915> > > Summary: Fixed windows grace opening of results in windows > Project: relax > Submitted by: tlinnet > Submitted on: Mon 17 Jun 2013 02:47:51 PM GMT > Category: relax's source code > Severity: 3 - Normal > Priority: 5 - Normal > Status: None > Privacy: Public > Assigned to: None > Originator Name: > Originator Email: > Open/Closed: Open > Discussion Lock: Any > Release: Branches > Operating System: GNU/Linux > > _______________________________________________________ > > Details: > > The RE path separator search did not work, producing errors > that the xmgrace was not in path. > > Added patch > > > > > _______________________________________________________ > > File Attachments: > > > ------------------------------------------------------- > Date: Mon 17 Jun 2013 02:47:51 PM GMT Name: patch Size: 1kB By: tlinnet > > <http://gna.org/bugs/download.php?file_id=18101> > > _______________________________________________________ > > Reply to this item at: > > <http://gna.org/bugs/?20915> > > _______________________________________________ > Message sent via/by Gna! > http://gna.org/ > > > _______________________________________________ > relax (http://www.nmr-relax.com) > > This is the relax-devel mailing list > [email protected] > > To unsubscribe from this list, get a password > reminder, or change your subscription options, > visit the list information page at > https://mail.gna.org/listinfo/relax-devel _______________________________________________ relax (http://www.nmr-relax.com) This is the relax-devel mailing list [email protected] To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
