Ok, I was just unsure from the message. It's useful to be a bit more verbose so that the text is understandable to users who read the release notes.
Cheers, Edward On 30 April 2014 16:36, Troels Emtekær Linnet <[email protected]> wrote: > Hi Edward. > > Well, okay here the message is to short. > Important is. > turn_on_local_dir_test = False > > But I also added extra tests. > > 2014-04-30 16:25 GMT+02:00 Edward d'Auvergne <[email protected]>: >> Hi Troels, >> >> This commit message also doesn't seem to match the changes. Are the >> changes correct? >> >> Cheers, >> >> Edward >> >> >> >> On 30 April 2014 15:05, <[email protected]> wrote: >>> Author: tlinnet >>> Date: Wed Apr 30 15:05:52 2014 >>> New Revision: 22893 >>> >>> URL: http://svn.gna.org/viewcvs/relax?rev=22893&view=rev >>> Log: >>> Turning off local dir writing in systemtest and set the correct time_T2. >>> >>> bug #21995: (https://gna.org/bugs/index.php?21995) Creating sherekhan input >>> files, with data for several fields and different time_T2 >>> >>> Modified: >>> trunk/test_suite/system_tests/relax_disp.py >>> >>> Modified: trunk/test_suite/system_tests/relax_disp.py >>> URL: >>> http://svn.gna.org/viewcvs/relax/trunk/test_suite/system_tests/relax_disp.py?rev=22893&r1=22892&r2=22893&view=diff >>> ============================================================================== >>> --- trunk/test_suite/system_tests/relax_disp.py (original) >>> +++ trunk/test_suite/system_tests/relax_disp.py Wed Apr 30 15:05:52 2014 >>> @@ -3826,7 +3826,7 @@ >>> # Define how files should look like >>> data_set_600 = [ >>> "60.8272464287\n", >>> - "0.04\n", >>> + "0.06\n", >>> "# nu_cpmg (Hz) R2eff (rad/s) Error >>> \n", >>> "# G10\n", >>> " 33.333 26.5355607871143 >>> 0.523610477116325\n", >>> @@ -3866,6 +3866,7 @@ >>> file = open(files[0][0]+sep+files[0][1]) >>> lines = file.readlines() >>> file.close() >>> + self.assertEqual(len(data_set_600), len(lines)) >>> for i in range(len(data_set_600)): >>> # Make the string test >>> self.assertEqual(data_set_600[i], lines[i]) >>> @@ -3917,12 +3918,13 @@ >>> file = open(files[1][0]+sep+files[1][1]) >>> lines = file.readlines() >>> file.close() >>> + self.assertEqual(len(data_set_500), len(lines)) >>> for i in range(len(data_set_500)): >>> # Make the string test >>> self.assertEqual(data_set_500[i], lines[i]) >>> >>> # Test local dir tests. This will be turned off in system test. >>> - turn_on_local_dir_test = True >>> + turn_on_local_dir_test = False >>> >>> if turn_on_local_dir_test: >>> ## Now check to local folder with None argument. >>> >>> >>> _______________________________________________ >>> relax (http://www.nmr-relax.com) >>> >>> This is the relax-commits mailing list >>> [email protected] >>> >>> To unsubscribe from this list, get a password >>> reminder, or change your subscription options, >>> visit the list information page at >>> https://mail.gna.org/listinfo/relax-commits >> >> _______________________________________________ >> relax (http://www.nmr-relax.com) >> >> This is the relax-devel mailing list >> [email protected] >> >> To unsubscribe from this list, get a password >> reminder, or change your subscription options, >> visit the list information page at >> https://mail.gna.org/listinfo/relax-devel _______________________________________________ relax (http://www.nmr-relax.com) This is the relax-devel mailing list [email protected] To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
