It looks like it is ready for a merge back to trunk :) I can look after the rest! We then have to work out how we release this - by itself as relax 3.2.4, or with the API changes in the zooming_grid_search branch as relax 3.3.0.
Cheers, Edward On 22 July 2014 18:21, Troels Emtekær Linnet <tlin...@nmr-relax.com> wrote: > 2014-07-22 18:08 GMT+02:00 Edward d'Auvergne <edw...@nmr-relax.com>: >> Hi, >> >> It all looks good, but you just have a few fixes for the last few >> commits with the broken equations in docstrings due to spacing >> changes. You can find these with: >> >> $ grep "\\\\$" lib/dispersion/* >> $ grep "i = 2" lib/dispersion/* > > This is done. > >> I have some more responses below: >> >> >>>> - There are some empty lines straight after a 'for' loop in many places. >>> >>> Done >> >> There are a few more, just search for the text "for ei in >> range(self.NE" in the target function. > > These are gone. > I cant find any more left? > Searching for "for ei in " > >> >>>> - There are some FIXME comments in the lib.dispersion package. >>> >>> They are not critical, and are in module which is not used yet. >> >> Ok. >> >> >>>> - In some places, comment lines require empty lines before them (in >>>> target_functions.relax_disp and lib.dispersion). >>> >>> Where? Can you give example? >> >> You also fixed some of the empty lines before comments formatting, but >> there are still some in target_function/relax_disp.py. For example >> see "# Structure of r20a and r20b. The full and outer dimensions >> structures.". There are a few in the __init__() method. > > Now done. > >> >>>> - The newline spacing between target function methods needs some fixes. >>> >>> Done? >> >> It looks done :) >> >> Cheers, >> >> Edward _______________________________________________ relax (http://www.nmr-relax.com) This is the relax-devel mailing list relax-devel@gna.org To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
