A table might be the best way to document this. It should include all models and the table can be added to the manual (as a new section or an expansion of the current nested parameter description). I would highly recommend that unit tests are created, one for each model, to make sure that the nesting occurs correctly and as expected for all models.
Cheers, Edward On 18 August 2014 15:36, Edward d'Auvergne <edw...@nmr-relax.com> wrote: > Hi Troels, > > This change requires a bit of work. Firstly the functions would be > better in their own module, as in the case of the > specific_analyses.model_free.model module. Secondly could you > document the parameter nesting you implemented in the nesting_model() > function? Is this different to the nesting() method of the Relax_disp > auto-analysis? What is its purpose? There are many ways to nest test > dispersion models, but here I am confused as to what is happening and > why. > > Cheers, > > Edward > > > > On 12 August 2014 10:54, <tlin...@nmr-relax.com> wrote: >> Author: tlinnet >> Date: Tue Aug 12 10:54:39 2014 >> New Revision: 24984 >> >> URL: http://svn.gna.org/viewcvs/relax?rev=24984&view=rev >> Log: >> Implemented nesting function, which will determine which model to nest from. >> >> sr #3135(https://gna.org/support/?3135): Optimisation of the R1 relaxation >> rate for the off-resonance R1rho relaxation dispersion models. >> >> Modified: >> branches/R1_fitting/specific_analyses/relax_disp/variables.py >> >> branches/R1_fitting/test_suite/unit_tests/_specific_analyses/_relax_disp/test_variables.py >> >> [This mail would be too long, it was shortened to contain the URLs only.] >> >> Modified: branches/R1_fitting/specific_analyses/relax_disp/variables.py >> URL: >> http://svn.gna.org/viewcvs/relax/branches/R1_fitting/specific_analyses/relax_disp/variables.py?rev=24984&r1=24983&r2=24984&view=diff >> >> Modified: >> branches/R1_fitting/test_suite/unit_tests/_specific_analyses/_relax_disp/test_variables.py >> URL: >> http://svn.gna.org/viewcvs/relax/branches/R1_fitting/test_suite/unit_tests/_specific_analyses/_relax_disp/test_variables.py?rev=24984&r1=24983&r2=24984&view=diff >> >> >> _______________________________________________ >> relax (http://www.nmr-relax.com) >> >> This is the relax-commits mailing list >> relax-comm...@gna.org >> >> To unsubscribe from this list, get a password >> reminder, or change your subscription options, >> visit the list information page at >> https://mail.gna.org/listinfo/relax-commits _______________________________________________ relax (http://www.nmr-relax.com) This is the relax-devel mailing list relax-devel@gna.org To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
