On 22 March 2012 13:29, Christian Persch <[email protected]> wrote:
> Wouldn't it be better to make this a *successful* return
> (after all, nothing went wrong, all requested packages were
> installed :-) ) instead of an error?
Yes, of course, makes sense:
diff --git a/src/gpk-dbus-task.c b/src/gpk-dbus-task.c
index 2f3a6ed..065c213 100644
--- a/src/gpk-dbus-task.c
+++ b/src/gpk-dbus-task.c
@@ -1221,6 +1221,10 @@ gpk_dbus_task_install_package_names
(GpkDbusTask *dtask, gchar **packages, GpkDb
string = g_string_new ("");
len = g_strv_length (packages);
+ if (len == 0) {
+ gpk_dbus_task_dbus_return_value (dtask, TRUE);
+ goto out;
+ }
/* don't use a bullet for one item */
Richard.
_______________________________________________
[email protected]
http://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.
