ons 2017-03-15 klockan 13:38 -0400 skrev Matthias Clasen:
> On Wed, Mar 15, 2017 at 9:24 AM, Marcus Lundblad <[email protected]>
> wrote:
> > ons 2017-03-15 klockan 14:21 +0100 skrev Andre Klapper:
> >
> > > On Wed, 2017-03-15 at 11:07 +0100, Marcus Lundblad wrote:
> >
> > > > There's been an issue popping up latelty with Maps not being
> > able
> >
> > > > to
> >
> > > > access GOA when running inside a Flatpak (https://bugzilla.gnom
> > e.or
> >
> > > > g/sh
> >
> > > > ow_bug.cgi?id=779975). Even though this should hopefully be
> > fixed
> >
> > > > in
> >
> > > > Flatpak, this could potentially happen also when running in a
> > non-
> >
> > > > GNOME
> >
> > > > environment without the GOA daemon.
> >
> > > > So, I'd like to reuest a freeze exception for the patch in the
> >
> > > > above
> >
> > > > bug (it will gracefully just hide the "Check in" button when
> >
> > > > creating
> >
> > > > the GOA client fails, this is not entirely new behavior either,
> > as
> >
> > > > this
> >
> > > > should already happen when there is no "check in:able" account
> >
> > > > configured in GOA). Also, there is no new translatable string
> > in
> >
> > > > the
> >
> > > > patch.
> >
> > >
> >
> > > Do you plan to attach an updated patch based on feedback in
> >
> > > https://bugzilla.gnome.org/show_bug.cgi?id=779975#c3 ?
> >
> > >
> >
> > > andre
> >
> >
> >
> > Yes, that's the plan. I think Carlos' suggestions made good sense.
>
> I'm going to say +1 already, but seeing the final, minimal fix would
> be good.
>
I have updated the patch to make the utility function acting on account
changes less dependent on guarding-ifs when run in _init().
//Marcus
_______________________________________________
[email protected]
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.
