On Friday 04 of January 2008, Alexander Neundorf wrote: > Yes, it is very unlikely, but very unlikely != impossible. > The thing is, the names were in sync with the names of the variables in the > FindX11.cmake of cmake cvs since several months. > So since several months some cmake cvs users may already use that variable. > Ok, it is the cvs version only, but still it is there for quite some time > already and changing this can break the build of somebody (you never know > what somebody does with the variables). So this change means either we can > never use the module from cmake or I need to add some transition logic on > the cmake side. > So is it really necessary to change the name ?
I guess that depends on which of changing a rarely used name from cmake cvs and having a confusing rarely used name you consider to be worse. > > > We are at the day of the tagging, IMO too late for such changes. > > > > It was broken. > > In which way was it exactly broken ? Somebody got confused by the names and it didn't match in kdebase/workspace/CMakeChecks.cmake. -- Lubos Lunak KDE developer -------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: [EMAIL PROTECTED] , [EMAIL PROTECTED] Lihovarska 1060/12 tel: +420 284 028 972 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http//www.suse.cz _______________________________________________ release-team mailing list [email protected] https://mail.kde.org/mailman/listinfo/release-team
