Should I wait for more approvals or can I commit it? Thanks --Marty
On Mon, Jun 6, 2011 at 21:03, Olivier Goffart <[email protected]> wrote: > No objections from me. > > Le Monday 06 June 2011, Martin Klapetek a écrit : > > Hi KDE Release team! > > > > I'd like to ask for an exception for a small patch adding a nice (and > > important) feature into KNotify. Let me explain - currently you can set > > only one icon for all your notification events. But if you have events > > like error and info, one icon is just not enough. So this patch allows > you > > to set an icon per defined event. For example, in KDE-Telepathy, we aim > > for deep system integration and this patch is really important for us, so > > we can use different icons per event as we have several different events, > > info, error and warning. With the desktop integration in mind, it makes > > perfect sense to not use any generic Telepathy icon, but rather a special > > icon for all the events. And I'd like to get this patch in for KDE 4.7, > > because otherwise we could start using this as soon as January, which is > a > > bit unfortunate. The patch itself is backwards compatible, so totally > > nothing would be broken and everyone would only gain. It was reviewed and > > approved (see [0]). > > > > So, I'm kindly asking you for an exception to let this patch in for 4.7. > > Would that please be possible? > > > > Thanks, > > --Marty > > > > [0] - https://git.reviewboard.kde.org/r/101470/ > >
_______________________________________________ release-team mailing list [email protected] https://mail.kde.org/mailman/listinfo/release-team
