On 10/31/2011 10:10 AM, Aaron J. Seigo wrote: > On Monday, October 31, 2011 14:15:40 David Faure wrote:
I was going to write back with some of the points that Aaron made, but, he made them. :-) From a [email protected] perspective we've had some complaints over the past couple of years about KWallet's architecture. Speaking with that hat on, it'd be really nice for KWallet to transition to KSS before [whenever Frameworks 5 comes out], and to maintain API compatibility having them as pluggable backends seems like it should work. One other comment: "qRegisterMetaType<SecretStruct>(); which do not include the namespace; i seem to recall having issues in certain places in Plasma where these meta type registrations required the use of the namespace so that code that did variant.value<KSecretsSevice::SecretStruct>() would still work properly as expected. perhaps i'm mis-remembering here, but this should be checked into before we ship it..." I'd like to echo that (personally, not with my security@ hat on). It also doesn't affect just QVariants, but AFAIK signals and slots too. If you register it like that, you force people to use a namespace in their code, when ideally that shouldn't be required if they simply want to scope everything. --Jeff
signature.asc
Description: OpenPGP digital signature
_______________________________________________ release-team mailing list [email protected] https://mail.kde.org/mailman/listinfo/release-team
