On Thu, Sep 13, 2012 at 11:39 AM, Ralf Jung <[email protected]> wrote: > Hi, > > > First, sorry I confused kdelibs with kde-baseapps in this response. So > > forget what I said about changes being merged back into 4.10 branch by > > David. Anyhow, I have now attempted to fix this issue as reported here. > See > > > > > http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b > > . > > > > However this fix does not really work. That is compile will fail if KDE > > version is changed to 4.9.2 as well because Qt's moc processor does not > > seem to correctly handle #if macros. So my question is whether it would > be > > acceptable for me to revert this change from the git 4.9 branch and > simply > > leave it as it was in the git master branch ? IOW, kde-baseapps 4.10 > > release will have a minimum requirement of kdelibs 4.9.2 ? >
> To make things worse, this commit cherry-picked onto kde-baseapps master > breaks compilation against kdelibs master. I had to revert 965fc6b3 to > succeed with compilation. Yes, that is why there a pending review to fix it: See https://git.reviewboard.kde.org/r/106438/.
_______________________________________________ release-team mailing list [email protected] https://mail.kde.org/mailman/listinfo/release-team
