El Dissabte, 31 d'agost de 2013, a les 11:20:30, Aurélien Gâteau va escriure: > Short version: > > I am very sorry to come up this late, I was on vacation and missed > 4.11.1 freeze day: I would like to request reverting a kdelibs commit I > made from the 4.11.1 kdelibs tarball. > > Long version: > > Shortly after KDE SC 4.11.0 got released I investigated Gwenview bug > 322850: > > https://bugs.kde.org/show_bug.cgi?id=322850 > > I made a commit in kdelibs to fix it: > > https://git.reviewboard.kde.org/r/111953 > > Unfortunately this commit causes a bad regression in Gwenview: when one > removes an image, Gwenview does not go to the next image anymore. I have > a patch fixing this in reviewboard: > > https://git.reviewboard.kde.org/r/112061 > > But that patch has not been reviewed and I don't feel comfortable asking > for it to be applied for 4.11.1, so I would like to ask for a revert of > the commit I made in kdelibs, commit-id: > 14e2ff5b7359d572cd520fd7da3791230ded169a. > > I will ensure Gwenview patch is properly reviewed and integrated in time > for 4.11.2 so that kdelibs commit can be applied again. > > Again, I am sorry for the mess.
Can the thing you broke/regressed be unittested so the thing doesn't break again while trying to fix something else? Cheers, Albert > > Aurélien > > _______________________________________________ > release-team mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/release-team _______________________________________________ release-team mailing list [email protected] https://mail.kde.org/mailman/listinfo/release-team
