----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123074/#review77768 -----------------------------------------------------------
I have to admit that I am unable to review these changes, because I have no idea what the proposed changes do and I do not run Plasma 5 yet. The applications start fine on Plasma 4. On the other hand, if this is needed to fix the bug, then the added dependency should not block the review. Actually, with the splitted frameworks, it would be a bit ugly if we could not use all of the old kdelibs4 features, just because they happen to be in a framework which wasn't used yet. Additionally, https://bugs.kde.org/show_bug.cgi?id=344896#c4 mentions several other apps, and says "many games", so either all of them need to be fixed, or we have to check why Plasma 5 works differently than the old Plasma and fix it there. - Christoph Feck On March 19, 2015, 8:28 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123074/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 8:28 p.m.) > > > Review request for Release Team, Christoph Feck and Laurent Montel. > > > Bugs: 344896 > http://bugs.kde.org/show_bug.cgi?id=344896 > > > Repository: kcharselect > > > Description > ------- > > Due to how desktop file's set up, we need to register to DBus, otherwise > klauncher isn't happy. > Adding Albert due to new dep > > > Diffs > ----- > > CMakeLists.txt 2276d23 > main.cc 2f8c4ba > > Diff: https://git.reviewboard.kde.org/r/123074/diff/ > > > Testing > ------- > > The bug is no more. > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ release-team mailing list [email protected] https://mail.kde.org/mailman/listinfo/release-team
