> On Nov. 9, 2015, 9:56 p.m., David Edmundson wrote: > > app/kipiinterface.cpp, line 463 > > <https://git.reviewboard.kde.org/r/125986/diff/1/?file=415688#file415688line463> > > > > why not > > > > return new KIPI::FileReadWriteLock(url);
sorry, didn't mean to post that comment. I thought I'd deleted it (stupid RB). This method won't be called anyway. This is fine. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125986/#review88171 ----------------------------------------------------------- On Nov. 8, 2015, 9:58 p.m., Shlomi Fish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125986/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2015, 9:58 p.m.) > > > Review request for Digikam, Gwenview and Release Team. > > > Repository: gwenview > > > Description > ------- > > This patch allows gwenview to build against the new versions of libkipi, and > retains compatibility with older ones. See > https://mail.kde.org/pipermail/release-team/2015-November/009108.html > > > Diffs > ----- > > app/kipiinterface.h d3961e9 > app/kipiinterface.cpp 8f71700 > > Diff: https://git.reviewboard.kde.org/r/125986/diff/ > > > Testing > ------- > > > Thanks, > > Shlomi Fish > >
_______________________________________________ release-team mailing list [email protected] https://mail.kde.org/mailman/listinfo/release-team
