I don't really follow Kate development, but this is serious enough and the patch looks good to me, so I took the "be bold" Wikipedia guideline and cherry-picked the commit to 15.12.
Let me know if I broke something. -- Nicolás 2015-12-13 20:42 GMT-03:00 Albert Astals Cid <[email protected]>: > El Sunday 13 December 2015, a les 20:49:54, Christoph Cullmann va escriure: >> Hi, >> >> it seems that we need fixes for 15.12, see kwrite devel and release >> coordination list. > > Can someone please commit it then? > > Cheers, > Albert > >> >> I am not sure if the kxmlgui change is a good idea, as all old Kate versions >> will no longer close sanely if people update their frameworks :/ >> >> Greetings >> Christoph >> >> ----- Am 13. Dez 2015 um 18:04 schrieb Albert Astals Cid [email protected]: >> > El Sunday 13 December 2015, a les 14:23:17, Andreas Sturmlechner va > escriure: >> >> > Hi >> >> > >> >> > With changes in Frameworks 5.17.0, Kate 15.11.90 no longer closes >> >> > properly. Quit the GUI, the app keeps running in Taskmanager for >> >> > example. >> >> > Bigger problem this causes is that on reboot you can have 15-20 >> >> > instances >> >> > of Kate opening right away. >> >> > >> >> > [cut] >> >> > >> >> > Anke >> >> > demm at kaosx.us >> >> >> >> Indeed, though at first it looks like a dbus timeout (because file open >> >> with kate breaks as well) all I needed was kate commit >> >> cd0163d7b956ace0e786a76d8211d06790a2c174 to fix this issue (I also >> >> backported to 15.08.3). This should really be fixed before 15.12.0 >> >> release. >> >> It doesn't appear to cause any pre-5.17 breakage since it previously only >> >> worked by kxmlgui overriding it anyway, according to the commit message. >> > >> > Do I understand it correctly that KDE Frameworks 5.17 has been released >> > with a change that makes existing code break? >> > >> > Is that because that existing code was broken to start with? >> > >> > Can someone that understands the code better than me please reach to the >> > conclusion, if what needs fixing is KDE Frameworks or kate and if kate >> > needs fixing apply the fix on the branches we're releasing and not only >> > in master? >> > >> > Cheers, >> > >> > Albert >> > >> >> Andreas _______________________________________________ release-team mailing list [email protected] https://mail.kde.org/mailman/listinfo/release-team
