Packagers: if you're using gcc 6, please integrate the fix below into your existing kdelibs4 packages as soon as possible, given that it made linking of kde4 apps (creating shared libs) impossible on Fedora 24, Arch Linux, OpenSuSE Tumbleweed, and probably others. (symbols marked as exported, were not actually exported)
---------- Forwarded Message ---------- Subject: Re: Review Request 128697: Fix wrong value of __KDE_HAVE_GCC_VISIBILITY on systems with gcc 6. Date: mardi 16 août 2016, 14:04:12 CEST From: David Faure <[email protected]> To: Allen Winter <[email protected]> CC: kdelibs <[email protected]>, David Faure <[email protected]> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128697/ ----------------------------------------------------------- (Updated Aug. 16, 2016, 2:04 p.m.) Status ------ This change has been marked as submitted. Review request for kdelibs and Allen Winter. Changes ------- Submitted with commit e9b25c7c040d8526fe8675b97d1067c8ffa7249f by David Faure to branch KDE/4.14. Repository: kdelibs Description ------- Clearly the author of this regexp, in 2006, thought gcc would never hit version 6 :-) Diffs ----- cmake/modules/FindKDE4Internal.cmake 7d54b9b83b999f6a6e8541f8e8b89e0b2a105703 Diff: https://git.reviewboard.kde.org/r/128697/diff/ Testing ------- Before: kdemacros:/* #undef __KDE_HAVE_GCC_VISIBILITY */ After: kdemacros.h:#define __KDE_HAVE_GCC_VISIBILITY The impact of this was that symbols were no longer exported in shared libs that use the KDE_EXPORT macro, thus breaking linking. Thanks, David Faure ----------------------------------------- -- David Faure, [email protected], http://www.davidfaure.fr Working on KDE Frameworks 5
