On Sun, May 7, 2017 at 2:24 PM, José Manuel Santamaría Lema <[email protected]> wrote: > Hi David, > > thank you for adding the missing tarballs and the checks. > > I'm doing a test build of the tarballs for Kubuntu and I found an issue with > the translations fetching code autotesting. > > When building from the packages it fails, see the fail.txt attachment of this > message. > > This issue is also reproducible in KDE Neon, see the file adt-output/log from > adt-output.tar.xz here: > http://build.neon.kde.org/job/xenial_unstable_frameworks_extra-cmake-modules_adt/118/ > > I think the problem is in the _repository_name function, see the code: > function(_repository_name reponame dir) > execute_process(COMMAND git config --get remote.origin.url > OUTPUT_VARIABLE giturl > RESULT_VARIABLE exitCode > WORKING_DIRECTORY "${dir}") > > if(exitCode EQUAL 0) > string(REGEX MATCHALL ".+[:\\/]([-A-Za-z\\d]+)(.git)?\\s*" "" $ > {giturl}) > set(${reponame} ${CMAKE_MATCH_1}) > endif() > > if(NOT ${reponame}) > set(${reponame} ${CMAKE_PROJECT_NAME}) > endif() > set(${reponame} ${${reponame}} PARENT_SCOPE) > endfunction() > > So, if I'm understanding correctly the code, when building from the packages, > it falls back to ${CMAKE_PROJECT_NAME} > > Now, if we inspect the tests/KDEFetchTranslations/CMakeLists.txt file, we will > see this at the top: > project(KDEFetchTranslations) > so I think that's producing the issue. > > Could we get this fixed? > > Cheers.
HI José María, It's an error in the test, here's a patch that fixes it. https://phabricator.kde.org/D5741 Thanks for reaching out! Aleix
