And another knotes build failure that happens only with Qt 5.10.0-rc2:
../src/configdialog/knotecollectionconfigwidget.cpp:151:24: error: no member
named 'setRecursiveFiltering' in 'QSortFilterProxyModel'; did you mean
'setRecursiveFilteringEnabled'?
mCollectionFilter->setRecursiveFiltering(true);
^~~~~~~~~~~~~~~~~~~~~
setRecursiveFilteringEnabled
/usr/include/qt5/QtCore/qsortfilterproxymodel.h:112:10: note:
'setRecursiveFilteringEnabled' declared here
void setRecursiveFilteringEnabled(bool recursive);
^
1 error generated.
Patch attached.
ttyl
bero
On Saturday, December 02, 2017 21:28 CET, "Bernhard Rosenkraenzer"
<[email protected]> wrote:
> Hi,
> build failure in knotes:
>
> ../src/configdialog/knoteconfigdialog.cpp:213:86: error: 'changed' is a
> protected member of 'KCModule'
> connect(mDefaultTitle, &QLineEdit::textChanged, this,
> QOverload<>::of(&KCModule::changed));
>
> ~~~~~~~~~~^~~~~~~
> /usr/include/KF5/KConfigWidgets/kcmodule.h:377:10: note: must name member
> using the type of the current context 'KNoteMiscConfig'
> void changed();
> ^
> ../src/configdialog/knoteconfigdialog.cpp:320:114: error: 'changed' is a
> protected member of 'KCModule'
> connect(mCollectionConfigWidget,
> &KNoteCollectionConfigWidget::emitChanged, this,
> QOverload<>::of(&KCModule::changed));
>
> ~~~~~~~~~~^~~~~~~
> /usr/include/KF5/KConfigWidgets/kcmodule.h:377:10: note: must name member
> using the type of the current context 'KNoteCollectionConfig'
> void changed();
> ^
> 2 errors generated.
>
> Fix attached.
>
> ttyl
> bero
>
>
> On Friday, December 01, 2017 02:31 CET, Christoph Feck <[email protected]> wrote:
>
> > Hello packagers,
> >
> > *.tar.xz files are available at the usual "unstable" location.
> >
> > Please report issues, release for the RC is planned tomorrow.
> >
> > This time, I have two versions of REVISIONS_AND_HASHES, the first
> > includes all information created by the release script, the second omits
> > the l10n revision numbers, because l10n is no longer released
> > separately, and I wasn't sure if packagers need this information.
> >
> > REVISIONS_AND_HASHES at https://paste.kde.org/pwgjwaohf
> > REVISIONS_AND_HASHES_withOUT_l10n at https://paste.kde.org/pv53ggn9n
> >
> > My public key at
> > http://pgp.mit.edu/pks/lookup?op=get&search=0xF23275E4BF10AFC1DF6914A6DBD2CE893E2D1C87
> >
> > Thanks,
> > Christoph Feck
--- knotes-17.11.90/src/configdialog/knotecollectionconfigwidget.cpp.omv~ 2017-12-02 21:30:09.588503064 +0100
+++ knotes-17.11.90/src/configdialog/knotecollectionconfigwidget.cpp 2017-12-02 21:30:18.433522055 +0100
@@ -148,7 +148,7 @@ KNoteCollectionConfigWidget::KNoteCollec
mCollectionFilter = new KRecursiveFilterProxyModel(this);
#else
mCollectionFilter = new QSortFilterProxyModel(this);
- mCollectionFilter->setRecursiveFiltering(true);
+ mCollectionFilter->setRecursiveFilteringEnabled(true);
#endif
mCollectionFilter->setSourceModel(mDisplayNotifierProxyModel);
mCollectionFilter->setDynamicSortFilter(true);
