On 8/6/21 6:16 AM, Luigi Toscano wrote:
Nate Graham ha scritto:
I know we didn't get our ducks in a row earlier, and I apologize for that, but
I feel very strongly that this needs to go into 21.08. If it does not, then
we're shipping a controversial behavior change to users in 21.08 with no way
to go back to the previous behavior.

May I CC you all on the bug reports we're bound to receive? :p

Then maybe, given the timing, there could have been other options with less
risks, for example:
- revert the feature that led to this problem;
- inform the release team as soon as it was clear that a freeze-breaking
change was needed, before merging, maybe asking for a delay in the final tag.

Of course it's always possible to do better, but if you decide to revert the
commit, I'd kindly ask to wait at least two days after the first scripty run
before tagging the final version of dolphin, in order to give some time to
translators.


Noted for next time, thanks.

Unfortunately the merge request to fix the issue came in very recently so there was not a lot of time.

Reverting the controversial change in 21.08 to bypass the issue entirely is another option that I would support. Then the "sort hidden flies last" feature would ship in 21.12 and be off by default with a user-facing way to turn it on. I think this would be better than than on by default in 21.08 with no way to turn it off, and then off by default on 21.12. People don't like that kind of back-and-forth.

Elvis and Méven, what do you think?

Nate

Reply via email to