Ross Patterson wrote:
To be clear, I think the right thing to do here (and in almost any OO
situation) is to subclass rather than monkey-patch and membrane/remember
are explicitly oriented to be extended in this way. In fact the
argument should probably be made that this is exactly the right level
for using class inheritance and *not* the ZCA. IOW, please don't monkey
patch, or over-use the ZCA, use basic OO and subclass to create your own
member content type. This is not, of course, a membrane/remember issue
or even a ZCA issue but simply a Python/OO best practice issue.
Many of our clients want to be able to login using their email address.
It would be nice if remember could support this without requiring a
subclass.
From this, it looks like the only thing that *might* need
monkey-patching would be the wrapUser method. Am I missing anything?
I believe that is the smallest set of changes that are required for
email logins to work correctly. The comments above every method explain
why they need to be modified.
We run a few large sites which have a mix-match of username / email
logins in the same site. All member accounts are either pure remember or
a subclass and it all works with these patches.
Hedley
--
Archive:
http://www.openplans.org/projects/remember/lists/remember/archive/2009/06/1244110965837
To unsubscribe send an email with subject "unsubscribe" to
[email protected]. Please contact [email protected] for
questions.
