Martin, time for the waaaaay back machine... Rob Miller <[email protected]> writes:
> Ross Patterson wrote: >> Building on Wichert's recent good work on trunk, I refactored >> membrane trunk such that the only Archetypes imports are in the at >> sub-package, the tests or in the examples sub-package. I also >> removed any code that imports the examples package by default. So in >> theory, *using* membrane no longer requires Archetypes though I >> haven't tested this. > >> >> While doing this work I noticed that something in the at sub-package >> and I'd like to solicit input. >> >> The >> Products.membrane.plugins.usermanager.MembraneUserManager.authenticateCredentials >> method looks up an IMembraneUserAuth adapter to delegate to: >> >> https://dev.plone.org/collective/browser/Products.membrane/trunk/Products/membrane/plugins/usermanager.py#L84> >> The IMembraneUserAuth implementation in >> Products.membrane.at.authentication.Authentication.authenticateCredentials >> method in turn looks up an adapter to >> Products.membrane.at.interfaces.IUserAuthentication: >> >> https://dev.plone.org/collective/browser/Products.membrane/trunk/Products/membrane/at/authentication.py#L33> >> This seems like one layer of indirection too many. Is there a reason >> for this indirection? Should we remove/unify these? > > indeed there is. the original implementation only had the first > layer, but optilude wanted to be able to use content objects for > authentication (and other membership-related functionality) w/o the > content objects directly containing any membership-specific code: > > https://dev.plone.org/collective/changeset/26675/membrane/trunk/factories/authentication.py > > or, for the larger changeset: > > https://dev.plone.org/collective/changeset/26675 > > personally, i've never had a need to be so rigorous in keeping the > member-related functionality out of my content objects, so i don't > feel strongly about keeping or losing this, but i have no idea who may > be using this functionality. Can you summarize where this is/was used, if you still think it's necessary and why if so? Thanks! Ross -- Archive: http://www.coactivate.org/projects/remember/lists/remember/archive/2009/07/1247730310591 To unsubscribe send an email with subject "unsubscribe" to [email protected]. Please contact [email protected] for questions.
