Wait. I think Stephen's concern might be warranted. That's a huge jump - is it new libraries being pulled in? Are those libraries maintained and do they have any potential security vulnerabilities?
I'm not voting against the patch (as if I have a vote :-) ), it seems that what Stephen did was brilliant! But I do think just a large jump does justify a careful look at what's being brought into the binary. -- Justin B. Alcorn PGP Fingerprint A36D D691 C5B0 BE15 5A2A AF49 AA1C 372C On Tue, Feb 7, 2017 at 11:37 AM, Dianne Skoll <d...@roaringpenguin.com> wrote: > On Tue, 7 Feb 2017 10:49:36 +1100 > Stephen Morgan <morgan.stephe...@gmail.com> wrote: > > > I've written a couple of patches to add some moon-related > > functionality to remind. The first is a simple patch to create the > > moonillum function, which gets the percentage of the moon's surface > > which is illuminated at a given time. > > Thank you! I will take a look. > > > The second patch, which is a bit more troublesome, allows remind to > > get the times of moonrise and moonset on a given date, accurate to > > within 3 minutes of the United States Naval Observatory moonrise/set > > tables (RMS variation 0.7 minutes, at least for the dates I've > > checked). > > Nice. > > > The only problem is that the implementation I've used adds a > > significant amount of code, mostly copied verbatim from this > > implementation of ELP 2000-82B > > (https://github.com/variar/elp2000-82b). This adds 2.7MB of code, and > > increases the size of the resulting binary from ~500kB to ~3.1MB. > > :) It's so quaint to see concern about a 3.1MB binary in 2017! I don't > think it'll be a problem. > > Thanks so much for doing this work. > > Regards, > > Dianne. > _______________________________________________ > Remind-fans mailing list > Remind-fans@lists.roaringpenguin.com > http://lists.roaringpenguin.com/cgi-bin/mailman/listinfo/remind-fans > Remind is at http://www.roaringpenguin.com/products/remind >
_______________________________________________ Remind-fans mailing list Remind-fans@lists.roaringpenguin.com http://lists.roaringpenguin.com/cgi-bin/mailman/listinfo/remind-fans Remind is at http://www.roaringpenguin.com/products/remind