On Wed, 28 Aug 2019 15:49:56 +0200
Denis 'GNUtoo' Carikli <gnu...@cyberdimension.org> wrote:

> Once the source code is downloaded and the dependencies are
> installed, it makes it easier for people to build Replicant.
> 
> It also saves the builds logs, to enable to later look at why
> the build failed without needing to re-run the build.
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <gnu...@cyberdimension.org>
This version fails without bash with:
> build/envsetup.sh: Syntax error: "(" unexpected

When I look at build/envsetup.sh it contains way too many dependencies
on bash:

> $ checkbashisms envsetup.sh
[...]
> possible bashism in envsetup.sh line 112 (bash arrays,
> ${name[0|*|@]}):
>    for v in ${VARIANT_CHOICES[@]}
[...]

So using source and bash makes sense.

I'll update the build instructions to explicitly add bash as
a dependency.

Before migrating the build instructions to use this script we would
also need to make at least the following improvements:
- It should be possible to disable sync to enable to test patches
  or work on the code locally. Ideas are welcome on how the interface
  with that should look like, or if the sync should be removed from the
  script completely. The idea is to make it easier for beginners to
  build Replicant, and also automatize things for people building it
  regularly.
- The supported machines could be deduced from the targets file in the
  same directory to improve maintainability.

Denis.

Attachment: pgpswg_dKSi1a.pgp
Description: OpenPGP digital signature

_______________________________________________
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant

Reply via email to