There is no point of bundling a copy of libsamsung-ipc in the
tools.

It's also counter-intuitive as developers do expect the tools
to be able to test the same libsamsung-ipc that is used by
the system and not a separate copy.

Without that we also have some compilation issue with ipc-modem.
  external/libsamsung-ipc/samsung-ipc/rfs.c:55: error: undefined reference to 
'MD5_Init'
  external/libsamsung-ipc/samsung-ipc/rfs.c:56: error: undefined reference to 
'MD5_Update'
  external/libsamsung-ipc/samsung-ipc/rfs.c:57: error: undefined reference to 
'MD5_Update'
  external/libsamsung-ipc/samsung-ipc/rfs.c:58: error: undefined reference to 
'MD5_Final'

Signed-off-by: Denis 'GNUtoo' Carikli <[email protected]>
---
 Android.mk | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/Android.mk b/Android.mk
index cca4bb7..cc108c3 100644
--- a/Android.mk
+++ b/Android.mk
@@ -137,9 +137,7 @@ LOCAL_MODULE_TAGS := optional
 LOCAL_SRC_FILES := tools/ipc-modem.c
 
 LOCAL_C_INCLUDES := $(LOCAL_PATH)/include
-
-LOCAL_STATIC_LIBRARIES := libsamsung-ipc
-LOCAL_SHARED_LIBRARIES := libutils
+LOCAL_SHARED_LIBRARIES := libsamsung-ipc
 
 include $(BUILD_EXECUTABLE)
 
@@ -155,7 +153,6 @@ LOCAL_SRC_FILES := tools/ipc-test.c
 
 LOCAL_C_INCLUDES := $(LOCAL_PATH)/include
 
-LOCAL_STATIC_LIBRARIES := libsamsung-ipc
-LOCAL_SHARED_LIBRARIES := libutils
+LOCAL_SHARED_LIBRARIES := libsamsung-ipc
 
 include $(BUILD_EXECUTABLE)
-- 
2.24.0

_______________________________________________
Replicant mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/replicant

Reply via email to