Hi, I think it would help a lot if links were sent to some web interface to get the context of the diff. I think in particular to the review of "[libsamsung-ipc][ 4/6] modem boot handlers: pass it the ipc_client struct".
In this case, some graphical tool could help to identify which part of the string has changed (in case of adding a parameter) like the `wdiff` tool. - Fil Lupin. On Sunday, February 16, 2020 3:58 PM, Denis 'GNUtoo' Carikli <[email protected]> wrote: > On Sat, 15 Feb 2020 23:38:34 +0000 > Fil Lupin [email protected] wrote: > But the issue is that I'm unsure of what would be the most > convenient way of doing it: > > - I could send the patches to be applied again on top of a known > revision. For instance lineageos/cm-13. I'm unsure how practical it > is to review as some of the information is not there (like it's > harder to do a diff with that). > > - I could point to a branch on a git repository but I'm unsure if it's > very convenient to review as it would increase the burden on the > people reviewing the patches, as they would need to go fetch that and > look at it instead of already having the patch to review right in the > mail. > > - I could do both: send patches, and also have them on a branch > somewhere. The time spent to do both is near 0 for me. > > Also do people wanting to review that kind of work have some idea on > which information to include, like a diff between the old and the new > rebase, or ways that would make it easier to review? _______________________________________________ Replicant mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/replicant
