On Thu, 19 Mar 2020 16:11:43 +0000 Fil Lupin <[email protected]> wrote:
> Hi, Hi, Thanks a lot for the review. > I tested devices.py with flake8, it does a static analysis and > identified a few correction to improve it > (https://lintlyci.github.io/Flake8Rules/): > > - line 20: os.environ['PYWIKIBOT_NO_USER_CONFIG']='1' I did it this way to make it more simple to use. Also if the users already have a configuration file, it would probably be used at some point. And as I didn't look into the configuration file yet, or how to use the script with Tor, I'm unsure if this is safe or not. > - line 27 an line 40: flake8 detects that it lakes one breakline > (https://www.flake8rules.com/rules/E302.html) > > - line 44, 46, 59 : line too long, we could cut line by adding \ at > the end of each cut end of line > (https://www.flake8rules.com/rules/E501.html) > > - line 68 : it lakes one breakline after the class definition > (https://www.flake8rules.com/rules/E305.html) I've fixed all that and more things along the way. I'll resend a v2 of both patch series combined. Denis.
pgp9owCygv96D.pgp
Description: OpenPGP digital signature
_______________________________________________ Replicant mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/replicant
