Hi,
in this mail I'm replying to the answers I got to my most recent mailing
list submission (published in Replicant Digest Vol 359 Issue 2).
First of all, thank you for your answers.
I reworked the commit messages of the patches (all new patches can be
found in the attachments).
Concerning the patch for i9300 inheriting wrongly from LineageOS:
I reworked the patch I sent last same. As Denis pointed out, this has
been already fixed in Replicant 9, which I did not notice until he
replied to my message in which I proposed a patch for that. I added this
background information to that patch, thank you for letting me know.
Yours,
Tobias
>From b6691459cc196b69bf9d951634f09be4db5947ba Mon Sep 17 00:00:00 2001
From: Tobias Tefke <[email protected]>
Date: Tue, 23 Jun 2020 15:50:36 +0200
Subject: [PATCH] Allow tools for building mesa
Mesa needs some external host tools tools that are not allowed by Soong.
We have to allow these tools,
otherwise error messages like the following will be displayed:
"xgettext" is not allowed to be used.
See https://android.googlesource.com/platform/build/+/master/Changes.md#PATH_Tools for more information.
Signed-off-by: Tobias Tefke <[email protected]>
Change-Id: Ife48e4ddf2f638b992a58e786a9680c98a40208b
---
ui/build/paths/config.go | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/build/paths/config.go b/ui/build/paths/config.go
index d17b9f77..becd9336 100644
--- a/ui/build/paths/config.go
+++ b/ui/build/paths/config.go
@@ -94,6 +94,8 @@ var Configuration = map[string]PathConfig{
"javap": Allowed,
"lsof": Allowed,
"m4": Allowed,
+ "msgfmt": Allowed,
+ "msgmerge": Allowed,
"nproc": Allowed,
"openssl": Allowed,
"patch": Allowed,
@@ -107,6 +109,7 @@ var Configuration = map[string]PathConfig{
"timeout": Allowed,
"tr": Allowed,
"unzip": Allowed,
+ "xgettext": Allowed,
"xz": Allowed,
"zip": Allowed,
"zipinfo": Allowed,
--
2.17.1
>From b26326defa9db37c47633ef48934000104b2761b Mon Sep 17 00:00:00 2001
From: Tobias Tefke <[email protected]>
Date: Mon, 22 Jun 2020 18:43:57 +0200
Subject: [PATCH] Properly inherit from LineageOS (call to nonexisting file)
Inheriting from vendor/lineage/config/common_phone.mk
does not work because this file does not exist.
Use vendor/lineage/config/common_full.mk instead.
This bug has been caused by the following commit:
f1555e9 HACK: Add userspace support for i9300
In Replicant 9 this error has been fixed in the following commit:
9aa8650: Add support for the modem
Signed-off-by: Tobias Tefke <[email protected]>
---
lineage_i9300.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lineage_i9300.mk b/lineage_i9300.mk
index 12ba55b..f367f4c 100644
--- a/lineage_i9300.mk
+++ b/lineage_i9300.mk
@@ -17,7 +17,7 @@
$(call inherit-product, $(SRC_TARGET_DIR)/product/aosp_base.mk)
$(call inherit-product, $(SRC_TARGET_DIR)/product/product_launched_with_p.mk)
$(call inherit-product, device/samsung/i9300/device.mk)
-$(call inherit-product, vendor/lineage/config/common_phone.mk)
+$(call inherit-product, vendor/lineage/config/common_full.mk)
$(call inherit-product, hardware/samsung/Android.mk)
PRODUCT_NAME := lineage_i9300
--
2.17.1
>From fc6a4983714892e6b6e00db98c3bb70608b09a53 Mon Sep 17 00:00:00 2001
From: Tobias Tefke <[email protected]>
Date: Mon, 22 Jun 2020 18:38:35 +0200
Subject: [PATCH] Replace vendorsetup.sh by COMMON_LUNCH_CHOICES
Still using vendorsetup generates the following warning message:
add_lunch_combo is obsolete.
Use COMMON_LUNCH_CHOICES in your AndroidProducts.mk instead.
We follow this new approach in order to silence this warning.
Signed-off-by: Tobias Tefke <[email protected]>
---
AndroidProducts.mk | 3 +++
vendorsetup.sh | 18 ------------------
2 files changed, 3 insertions(+), 18 deletions(-)
delete mode 100644 vendorsetup.sh
diff --git a/AndroidProducts.mk b/AndroidProducts.mk
index b168b09..2ce318b 100644
--- a/AndroidProducts.mk
+++ b/AndroidProducts.mk
@@ -16,3 +16,6 @@
PRODUCT_MAKEFILES := \
$(LOCAL_DIR)/lineage_i9300.mk
+
+COMMON_LUNCH_CHOICES := \
+ lineage_i9300-userdebug
diff --git a/vendorsetup.sh b/vendorsetup.sh
deleted file mode 100644
index d21fbce..0000000
--- a/vendorsetup.sh
+++ /dev/null
@@ -1,18 +0,0 @@
-#
-# Copyright 2018 Joonas Kylmälä
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-add_lunch_combo lineage_i9300-userdebug
-add_lunch_combo lineage_i9300-userdebug
--
2.17.1
>From d7900b4523c5ebde44c088a31617af63db42e53b Mon Sep 17 00:00:00 2001
From: Tobias Tefke <[email protected]>
Date: Mon, 22 Jun 2020 18:42:25 +0200
Subject: [PATCH] Replace vendorsetup.sh by COMMON_LUNCH_CHOICES
Still using vendorsetup generates the following warning message:
add_lunch_combo is obsolete.
Use COMMON_LUNCH_CHOICES in your AndroidProducts.mk instead.
We follow this new approach in order to silence this warning.
Signed-off-by: Tobias Tefke <[email protected]>
---
AndroidProducts.mk | 3 +++
vendorsetup.sh | 17 -----------------
2 files changed, 3 insertions(+), 17 deletions(-)
delete mode 100644 vendorsetup.sh
diff --git a/AndroidProducts.mk b/AndroidProducts.mk
index 37e30b4..5cdccd6 100644
--- a/AndroidProducts.mk
+++ b/AndroidProducts.mk
@@ -16,3 +16,6 @@
PRODUCT_MAKEFILES := \
$(LOCAL_DIR)/lineage_i9305.mk
+
+COMMON_LUNCH_CHOICES := \
+ lineage_i9305-userdebug
diff --git a/vendorsetup.sh b/vendorsetup.sh
deleted file mode 100644
index bf5fcfb..0000000
--- a/vendorsetup.sh
+++ /dev/null
@@ -1,17 +0,0 @@
-#
-# Copyright 2018 Joonas Kylmälä
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-add_lunch_combo lineage_i9305-userdebug
--
2.17.1
_______________________________________________
Replicant mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/replicant
