Hi,
When removing firmwares, the more testers we have the better: in some cases (like with the NFC firmwares), the builtin firmware works only for some devices (probably the ones produced later on, that have chips that got a firmware update to the builtin firmware and/or ROM code). So I wanted to test Belgin's patch because of that, and it worked fine on my device. So while I was at it, I saw that some functions were printed, like "synaptics_ts_set_power(0)" and so I tried to look for the prints and I didn't find what printed that. So instead of spending too much time on that I ended up implementing what I suggested, hence the v2 of this patch set. So I now need a review on my modifications as it's often easier to find mistakes from other people than our own mistakes (which are often fixed before sending the patch in the first place). Here what it prints with this new version of the patch: > root@n5100:/ # dmesg | grep -i tsp > [ 53.123991] c2 [TSP] ID: 0, x: 303, y: 1076, z: 76 > [ 53.124036] c2 [TSP] palm 0, surface_data 16, 0 > [ 53.500573] c2 [TSP] ID: 0 > [ 110.015459] c1 [TSP] synaptics_ts_led_control [2] > [ 111.791686] c0 [TSP] synaptics_ts_led_control [1] > [ 118.647329] c1 [TSP] synaptics_ts_led_control [2] > [ 120.460109] c2 [TSP] ID: 0, x: 396, y: 1218, z: 69 > [ 120.460254] c2 [TSP] palm 0, surface_data 15, 0 > [ 120.465624] c0 [TSP] synaptics_ts_led_control [1] > [ 121.157882] c2 [TSP] ID: 0 > [ 129.669122] c0 [TSP] synaptics_ts_led_control [2] > [ 150.770176] c0 [TSP] forced_release_buttons > [ 150.770199] c0 [TSP] synaptics_ts_set_power(0) So on my GT-N5100, no firmware loading functions were called by userspace. As for the power management functions, they are called at least from the board files. As I was recently told about new git functions like --range-diff and --cover-letter (for format-patch), while upstreaming some patches, I wanted to test them. This will hopefully make the review easier. The 0/1 contains a "range-diff"(I'm not sure of the name) patch that contains the differences between the old patch and this new one. It was generated with: $ git format-patch -v2 \ --range-diff=9abd347659771c49bcd17eb6a020c1cbe0a27427 \ --cover-letter HEAD -1 9abd347659771c49bcd17eb6a020c1cbe0a27427 being Belgin's version of the patch. In addition to that, this patch is also available in a web interface web interface: https://git.replicant.us/contrib/GNUtoo/kernel_samsung_smdk4412/commit/?id=43720e41c7f36873718fc24746277bbf7d24e6f1 And here's how to get it in a git repository: git clone https://git.replicant.us/GNUtoo/kernel_samsung_smdk4412 cd kernel_samsung_smdk4412 git show 43720e41c7f36873718fc24746277bbf7d24e6f1 Denis. _______________________________________________ Replicant mailing list Replicant@osuosl.org https://lists.osuosl.org/mailman/listinfo/replicant
