This separates more what is part of the header and what is not so things are more clear to the people reading the code.
In addition, having all includes statements inside the #ifdef #endif header guards avoids issues with the inclusion of headers that are missing such guards. This can happen with headers imported from vendor kernels. So while headers imported from vendor kernels are typically not included in the headers exported by libsamsung-ipc, it's still good to have a consistent code style between exported and non exported headers. Signed-off-by: Denis 'GNUtoo' Carikli <gnu...@cyberdimension.org> --- include/samsung-ipc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/samsung-ipc.h b/include/samsung-ipc.h index a03c748..3983ea5 100644 --- a/include/samsung-ipc.h +++ b/include/samsung-ipc.h @@ -19,11 +19,11 @@ * along with libsamsung-ipc. If not, see <http://www.gnu.org/licenses/>. */ -#include <sys/time.h> - #ifndef __SAMSUNG_IPC_H__ #define __SAMSUNG_IPC_H__ +#include <sys/time.h> + /* * Values */ -- 2.30.0 _______________________________________________ Replicant mailing list Replicant@osuosl.org https://lists.osuosl.org/mailman/listinfo/replicant