Michael Pedersen <rep...@icelus.org> added the comment:

Attaching a patch that was made by mcdonc. I just updated the test cases. This
patch should clear up the issue with the spaces pretty well entirely. I know it
did for my  use, anyway.

__________________________________
Repoze Bugs <b...@bugs.repoze.org>
<http://bugs.repoze.org/issue60>
__________________________________
Index: repoze/who/plugins/auth_tkt.py
===================================================================
--- repoze/who/plugins/auth_tkt.py      (revision 4111)
+++ repoze/who/plugins/auth_tkt.py      (working copy)
@@ -75,11 +75,11 @@
         cur_domain = environ.get('HTTP_HOST', environ.get('SERVER_NAME'))
         wild_domain = '.' + cur_domain
         cookies = [
-            ('Set-Cookie', '%s=%s; Path=/' % (
+            ('Set-Cookie', '%s="%s"; Path=/' % (
             self.cookie_name, value)),
-            ('Set-Cookie', '%s=%s; Path=/; Domain=%s' % (
+            ('Set-Cookie', '%s="%s"; Path=/; Domain=%s' % (
             self.cookie_name, value, cur_domain)),
-            ('Set-Cookie', '%s=%s; Path=/; Domain=%s' % (
+            ('Set-Cookie', '%s="%s"; Path=/; Domain=%s' % (
             self.cookie_name, value, wild_domain))
             ]
         return cookies
Index: repoze/who/tests.py
===================================================================
--- repoze/who/tests.py (revision 4111)
+++ repoze/who/tests.py (working copy)
@@ -1627,13 +1627,13 @@
         self.assertEqual(len(result), 3)
         self.assertEqual(result[0],
                          ('Set-Cookie',
-                          'auth_tkt=%s; Path=/' % new_val))
+                          'auth_tkt="%s"; Path=/' % new_val))
         self.assertEqual(result[1],
                          ('Set-Cookie',
-                           'auth_tkt=%s; Path=/; Domain=localhost' % new_val))
+                           'auth_tkt="%s"; Path=/; Domain=localhost' % 
new_val))
         self.assertEqual(result[2],
                          ('Set-Cookie',
-                           'auth_tkt=%s; Path=/; Domain=.localhost' % new_val))
+                           'auth_tkt="%s"; Path=/; Domain=.localhost' % 
new_val))
 
     def test_remember_creds_different_int_userid(self):
         plugin = self._makeOne('secret')
@@ -1646,7 +1646,7 @@
         self.assertEqual(len(result), 3)
         self.assertEqual(result[0],
                          ('Set-Cookie',
-                          'auth_tkt=%s; Path=/' % new_val))
+                          'auth_tkt="%s"; Path=/' % new_val))
 
     def test_remember_creds_different_long_userid(self):
         plugin = self._makeOne('secret')
@@ -1658,7 +1658,7 @@
         self.assertEqual(len(result), 3)
         self.assertEqual(result[0],
                          ('Set-Cookie',
-                          'auth_tkt=%s; Path=/' % new_val))
+                          'auth_tkt="%s"; Path=/' % new_val))
 
     def test_remember_creds_different_unicode_userid(self):
         plugin = self._makeOne('secret')
@@ -1673,7 +1673,7 @@
         self.assertEqual(len(result), 3)
         self.assertEqual(result[0],
                          ('Set-Cookie',
-                          'auth_tkt=%s; Path=/' % new_val))
+                          'auth_tkt="%s"; Path=/' % new_val))
 
     def test_forget(self):
         plugin = self._makeOne('secret')
@@ -1683,7 +1683,7 @@
         header = headers[0]
         name, value = header
         self.assertEqual(name, 'Set-Cookie')
-        self.assertEqual(value, 'auth_tkt=""; Path=/')
+        self.assertEqual(value, 'auth_tkt=""""; Path=/')
         header = headers[1]
         name, value = header
         self.assertEqual(name, 'Set-Cookie')
_______________________________________________
Repoze-dev mailing list
Repoze-dev@lists.repoze.org
http://lists.repoze.org/listinfo/repoze-dev

Reply via email to