Hi Paul, > EDID data is almost always proprietary so I'm not sure how to do that.
Something that at least has the first 'n' bytes or so so we can check that the "recognition" for this file type works would be the minimum here I think. > > * expand that TODO item, I can't understand what it is about > > diffoscope does not compare the output of the commands when one of them > returns an exit code other than zero. As far as I can tell this is > hard-coded in the File class, so I assumed this was a design choice? I believe Mattia was asking for this to be explained in the code itself - having info solely in the BTS will mean that it will quickly become arduous and time-consuming to find, let alone organically discover. However, I do not think diffoscope should have a global "check, regardless of UNIX return code of external tool" -- that should be up to each comparator to determine and feels very niche at this point. Thus, dropping the TODO line migh tbe best course of action here. > > * explain why the external_tools.py's dict lists both edid-decode and > > read-edid, but in the build-dep are made as alternatives > > Both are optional and only run if installed, either one is useful for > comparing the files but edid-decode shows more details. (Again, I believe the request was asking for this to be explained in the code itself.) Looking forward to receiving your updated patch. :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- _______________________________________________ Reproducible-builds mailing list Reproducible-builds@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/reproducible-builds