Comparing jars gives a stacktrace, looks like a missing import.

$ ./
Traceback (most recent call last):
  File "./", line 53, in <module>
  File "./", line 43, in main
    differences = debbindiff.comparators.compare_files(parsed_args.file1,
85, in compare_files
    return comparator(path1, path2, source)
line 51, in with_fallback
    inside_differences = original_function(path1, path2, source)
line 57, in compare_zip_files
    zipinfo1 = get_zipinfo(path1)
line 31, in get_zipinfo
    return re.sub(re.escape(path), os.path.basename(path), output)
NameError: global name 're' is not defined

Also, I updated the for two small things. I recommend using code
checkers like pyflakes and pylint:

$ pyflakes *.py debbindiff/*.py
debbindiff/ 'difflib' imported but unused
debbindiff/ redefinition of function 'comment' from line 37
hans@palatschinken debbindiff $ pylint *.py debbindiff/*.py


Hans-Christoph Steiner wrote:
> Definitely use  It makes the packaging easy and standardized, and it
> is the standard way to build python.  It also makes it easy to publish
> releases to pypi, the central package repository for python.  I attached a
> quick untested one for you.
> .hc
> Jérémy Bobbio wrote:
>> Hi!
>> I've been working at high pace since Sunday on a replacement for the
>> diffp script [1]. These GPLv3 lines of Python are called debbindiff.
>> Get it from Git:
>> Attached is an output produced for the attr package. The new tool is at
>> least as capable as diffp, is way more extensible, and the result is
>> more readable.
>> Example usage:
>>     $ ./ --html /tmp/debbindiff.html b1/*.changes b2/*.changes
>> There's no requirements for actually comparing .changes. You can use it
>> to compare jar files directly if that's your kick.
>> I'd love to see reviews of the code. It's scarce on comments but names
>> should be explicit enough, or so I hope.
>> It's missing Debian packaging. I guess I should learn how to write a
>> setup.cfg or similar. Pointers or patches welcome.
>> One thing this codebase should enable is writing “hints”. Once the tree
>> of differences is generated, it should be doable to run through it to
>> generate statements like: “Many files in data.tar have different
>> timestamps, dh_fixmtimes has probably not been called. Are you
>> using dh?” This still needs to be done though.
>> Last note: I've been pushing everything else aside while I had the
>> thrills to work on this. It's unclear when will be the next time, so
>> patches are preferred rather than suggestion.
>>  [1]:
>> _______________________________________________
>> Reproducible-builds mailing list

PGP fingerprint: 5E61 C878 0F86 295C E17D  8677 9F0F E587 374B BE81
#!/usr/bin/env python2

from setuptools import setup

      description='display differences between files',
          'Development Status :: 3 - Alpha',
          'Intended Audience :: Developers',
          'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
          'Operating System :: POSIX',
          'Topic :: Utilities',

Attachment: signature.asc
Description: OpenPGP digital signature

Reproducible-builds mailing list

Reply via email to