Your message dated Tue, 12 May 2015 09:49:50 +0000 with message-id <e1ys6ow-00058l...@franck.debian.org> and subject line Bug#784891: fixed in debbindiff 19 has caused the Debian Bug report #784891, regarding crashes comparing text files: TypeError: must be string, not list to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 784891: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=784891 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: debbindiff Version: 18 User: helm...@debian.org Usertags: rebootstrap >From a recent jenkins build: | https://jenkins.debian.net/job/rebootstrap_s390x_gcc49_nobiarch_debbindiff/18/console | Get:1 http://ftp.de.debian.org/debian/ sid/main gzip s390x 1.6-4 [111 kB] | Fetched 111 kB in 0s (1337 kB/s) | Traceback (most recent call last): | File "/usr/bin/debbindiff", line 120, in <module> | sys.exit(main()) | File "/usr/bin/debbindiff", line 106, in main | parsed_args.file1, parsed_args.file2) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/__init__.py", line 129, in compare_files | return comparator(path1, path2, source) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/utils.py", line 43, in with_fallback | inside_differences = original_function(path1, path2, source) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/deb.py", line 53, in compare_deb_files | in_path1, in_path2, source=name)) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/__init__.py", line 129, in compare_files | return comparator(path1, path2, source) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/utils.py", line 43, in with_fallback | inside_differences = original_function(path1, path2, source) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/xz.py", line 50, in compare_xz_files | source=[os.path.basename(new_path1), os.path.basename(new_path2)]) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/__init__.py", line 129, in compare_files | return comparator(path1, path2, source) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/utils.py", line 43, in with_fallback | inside_differences = original_function(path1, path2, source) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/tar.py", line 65, in compare_tar_files | source=name.decode('utf-8'))) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/__init__.py", line 129, in compare_files | return comparator(path1, path2, source) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/utils.py", line 43, in with_fallback | inside_differences = original_function(path1, path2, source) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/gzip.py", line 64, in compare_gzip_files | source=[os.path.basename(new_path1), os.path.basename(new_path2)])) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/__init__.py", line 129, in compare_files | return comparator(path1, path2, source) | File "/usr/lib/python2.7/dist-packages/debbindiff/comparators/text.py", line 29, in compare_text_files | file1 = codecs.open(path1, 'r', encoding=encoding) | File "/usr/lib/python2.7/codecs.py", line 887, in open | info = lookup(encoding) | TypeError: must be string, not list | rebootstrap-error: debbindiff terminated with abnormal exit code 2 In comparators.text, compare_text_files is defined as: | def compare_text_files(path1, path2, encoding, source=None): It is called at comparators/__init__.py:129 as: | return comparator(path1, path2, source) So it seems that the source variable there becomes the encoding parameter in compare_text_files, which seems strange at least. Now compare_text_files did have this signature from the very beginning and in a few places, it is called with that encoding explicitly. However it also shows up in the COMPARATORS list in comparators/__init__.py. The functions there are generally expected to be callable without the encoding parameter. Cc-ing Reiner Herrmann as he recently touched that code. Hope this helps in dissecting. Helmut
--- End Message ---
--- Begin Message ---Source: debbindiff Source-Version: 19 We believe that the bug you reported is fixed in the latest version of debbindiff, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 784...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Jérémy Bobbio <lu...@debian.org> (supplier of updated debbindiff package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Tue, 12 May 2015 10:35:48 +0200 Source: debbindiff Binary: debbindiff Architecture: source all Version: 19 Distribution: unstable Urgency: low Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org> Changed-By: Jérémy Bobbio <lu...@debian.org> Description: debbindiff - highlight differences between two builds of Debian packages Closes: 784891 Changes: debbindiff (19) unstable; urgency=low . [ Reiner Herrmann ] * Fix info files comparator by specifying the correct parameter name for the text comparator. (Closes: #784891) Checksums-Sha1: 1b7348dc0ee244b7c08b9ba93ae04e4db069a8ce 1764 debbindiff_19.dsc 381044457406c5d32ec58cc0151857122e51c11a 40682 debbindiff_19.tar.gz e2f2bee6ebebe4447fed5c2d172275f207a32690 27768 debbindiff_19_all.deb Checksums-Sha256: 4d5da398d8c6374f47d85211699078753bed65a58cda5da2906ad0d7cecedc74 1764 debbindiff_19.dsc 4ec30a38219c2e30495bf959a9078df529570cbb8ad754047f952e442536bb73 40682 debbindiff_19.tar.gz 9e0bd1f0beecbb0738bc0491ef34b3517eec3b51e095ec359648e310ee8505cc 27768 debbindiff_19_all.deb Files: dd8d38603a53032051f155e733a3784f 1764 devel optional debbindiff_19.dsc 19c93eb589a0dc7a58b17e06a5377a16 40682 devel optional debbindiff_19.tar.gz ab2a46dac82342afb8c3f9a2db593173 27768 devel optional debbindiff_19_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJVUb5eAAoJEEAsIlA9Nuk2XrUP/0eC4NVxxuy3+GuG8036Vjmp K2eLktqy2nZCHG2IgD4Rb0dNK7BI6uIatBX8xwr5hkVZjWwgfhfjBPqPzpQu6USP QTOSoOQEICVvO5IAs0xy73fdm+Zyixs88OsTDQYRy63HsqKn5KqNklqxPND6LXJF YiD0FLtqNRSPE7Zp/hO7OJaY6NSyl0astQGJFnLC9rsxzOUwqH06ItNzRKxP9+Yo 1yRnHvS8x+h970yEUHL4KBR00GxCYijFvpjWg6vHL7P67LZBD4IRKIqCXuCpO8uV wgQVeSNZ7Xwk0DB2wv4K7OZ/xbH2g+f4ylGtXAfw8/+96K8DMKyUfeJsoR7QkCka X6iZc8/LFqBJNrckKr5yRVxkz7J4fZD4Dq+HUH/WRHkFWgaD2/mvJxc+01sSlozr GxDblmNif7b/nGKt5ktm0+YYZ4uB4Kq/wNQMQzSIVp0tdEcFqdN697annhF2ukBG qFpQ70BlTO3smHuVav0MFfR2pSlGEVipARlVwW7LgsrkGxDfQlw5aQZZe1+0HsXx OrotPpd1v4IZNLl1kJG2sCa6uUMQRC4CmX2uKZVeY95seLj9n8iqNGlLqevxoyLI /xzWJVs4Gcu1ajRQ4m9IxPOjlO1rJajI8tTdpzZfTT1fIOJ0nSoZ5rfNneIoWgmB TzX3jUnlCsOnSkVCyceD =J1cR -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
