On Fri, Aug 07, 2015 at 10:20:02PM +0200, Dhole wrote:
> > The file you are patching here, ./configure, is autogenerated from another 
> > file
> > called ./configure.ac in the freeimpi sources. Maintainers are encouraged to
> > rebuild their ./configure file from ./configure.ac at build time for various
> > reasons but even if the freeimpi maintainer does not decide to do that in 
> > the
> > near future, your changes will probably be overwritten by the next upstream
> > release which changes the ./configure.ac and thus regenerates ./configure. 
> > It
> > is thus better to patch the source of ./configure in ./configure.ac about 
> > here:
> > http://sources.debian.net/src/freeipmi/1.4.9-1/configure.ac/#L109 and 
> > suggest
> > to upstream to call dh with `--with --autoreconf` instead of their current
> > `--with autotools_dev` in debian/rules.
> > 
> I actually missed the configure.ac! Thanks for noticing. I've written
> the patch targeting configure.ac now, and changed the dh from autotools
> to autoreconf (Otherwise only autoconfigure is used and the change
> doesn't get processed). I'll suggest the maintainer to do this change too.
> PS: I had to modify the Build-Depends: removing autotools-dev and adding
> dh-autoreconf. I hope that's the correct way.

Yes, that's the correct way to do autoreconfing in debian.
You might also be interested to read https://wiki.debian.org/Autoreconf

                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540         .''`.
more about me:  http://mapreri.org                                 : :'  :
Launchpad user: https://launchpad.net/~mapreri                     `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia     `-

Attachment: signature.asc
Description: Digital signature

Reproducible-builds mailing list

Reply via email to