On Fri, Sep 04, 2015 at 08:42:43AM +0200, Axel Beckert wrote:
 
> it seems that the Recommends of diffoscope are generated dynamically
> and all lost with the upload of version 32. Is this on purpose? If
> not, feel free to open a bug report in my name with this mail.

Thanks, looks like a bug to me. Trivial patch attached, hope it helps.
(Guess I could push it too but wasn't sure if there's a review process
 or something.)
-- 
Niko Tyni   nt...@debian.org
>From 36d2d4c132cb90e37b2c5ebceb3ad93734aac62c Mon Sep 17 00:00:00 2001
From: Niko Tyni <nt...@debian.org>
Date: Fri, 4 Sep 2015 09:55:37 +0300
Subject: [PATCH] Change remaining references of diffoscope.py, fixing package
 recommendations

The script was renamed to bin/diffoscope in 63523e8d2, but a couple of
references got overlooked, breaking the automatically generated list of
package recommendations.

Thanks to Axel Beckert for spotting this.
---
 README       | 4 ++--
 debian/rules | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/README b/README
index c8e1de7..f7e3e7c 100644
--- a/README
+++ b/README
@@ -24,7 +24,7 @@ debbindiff.
 Example
 -------
 
-    $ bin/diffoscope.py --html output.html build1.changes build2.changes
+    $ bin/diffoscope --html output.html build1.changes build2.changes
 
 This will compare `build1.changes` and `build2.changes` and create
 `output.html` if there are differences between the two files.
@@ -47,7 +47,7 @@ Required Python modules:
 The various comparators rely on external commands being available. To
 get a list of them, please run:
 
-    $ bin/diffoscope.py --list-tools
+    $ bin/diffoscope --list-tools
 
 Contributors
 ------------
diff --git a/debian/rules b/debian/rules
index 0c5ec78..263eeba 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,7 +13,7 @@ override_dh_auto_build:
 	dh_auto_build -O--buildsystem=pybuild
 
 override_dh_gencontrol:
-	echo "diffoscope:Recommends=$$(./diffoscope.py --list-tools | tail -n 1 | \
+	echo "diffoscope:Recommends=$$(bin/diffoscope --list-tools | tail -n 1 | \
 		sed -e 's/\(^\| \)\(coreutils\|diffutils\|e2fsprogs\|findutils\|gzip\)\(,\|$$\)//g')" >> debian/diffoscope.substvars
 	dh_gencontrol -O--buildsystem=pybuild
 
-- 
2.1.4

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to