Control: tag -1 - patch

On Tue, Oct 20, 2015 at 04:09:16PM -0400, Daniel Kahn Gillmor wrote:

> But doesn't the change from HashSet to List end up changing the behavior
> with regard to multiple children of the same class?
> 
> That is, if it's a List, then the same class can appear multiple times,
> whereas if it's a set, i think it just gets added once.

Yes, I think you're right. Thanks for catching that! I suspect it doesn't
really matter here, but I'm not quite sure, and it certainly isn't safe
as a general fix.
 
> The usual approach would be to sort the output where it's produced from
> the HashedSet, and not to change the data structure itself to allow
> duplicates.

Sure, this just seemed such a nice solution :)

Anyway, removing the 'patch' tag for now.
-- 
Niko Tyni   nt...@debian.org

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to