Source: pxz
Version: 4.999.99~beta4+gitae80846-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that pxz could not be built reproducibly.
There is a small bug in the existing reproducibility patch.
The output of dpkg-parsechangelog is piped to date, but date is not told
to read from stdin and still uses the system time.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

diff --git a/debian/patches/reproducible-build.patch b/debian/patches/reproducible-build.patch
index a5f6bed..d54972c 100644
--- a/debian/patches/reproducible-build.patch
+++ b/debian/patches/reproducible-build.patch
@@ -5,7 +5,7 @@
  
  $(NAME): $(SOURCES) $(OBJECTS)
 -	$(CC) -o $(NAME) $(CPPFLAGS) $(CFLAGS) $(NAME).c $(OBJECTS) $(LDFLAGS) -DPXZ_BUILD_DATE=\"`date +%Y%m%d`\" -DPXZ_VERSION=\"$(VERSION)\"
-+	$(CC) -o $(NAME) $(CPPFLAGS) $(CFLAGS) $(NAME).c $(OBJECTS) $(LDFLAGS) -DPXZ_BUILD_DATE=\"$(shell dpkg-parsechangelog -S date|date -u +%Y%m%d)\" -DPXZ_VERSION=\"$(VERSION)\"
++	$(CC) -o $(NAME) $(CPPFLAGS) $(CFLAGS) $(NAME).c $(OBJECTS) $(LDFLAGS) -DPXZ_BUILD_DATE=\"$(shell dpkg-parsechangelog -S date|date -u +%Y%m%d -f -)\" -DPXZ_VERSION=\"$(VERSION)\"
  
  clean:
  	rm -f *.o $(NAME)

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to