Source: lierolibre
Version: 0.5-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: locale
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that lierolibre could not be built reproducibly.
The shell script which is generating the sound data file is interpreting
the output of 'dd', which can be different in another language.
The script is already aware of that and is normalizing LANG,
but this is not sufficient, since LC_ALL has a higher priority.

The attached patch fixes this by overwriting LC_ALL instead of LANG.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/scripts/lierolibre-packsounds b/scripts/lierolibre-packsounds
index 4f85818..af1fd7d 100755
--- a/scripts/lierolibre-packsounds
+++ b/scripts/lierolibre-packsounds
@@ -61,7 +61,7 @@ hash sox 2>&- || { echo >&2 "This script requires the "'"SoX"'" audio manipulato
 inputdir="$1"
 outputfile="$2"
 names="SHOTGUN SHOT RIFLE BAZOOKA BLASTER THROW LARPA EXP3A EXP3B EXP2 EXP3 EXP4 EXP5 DIRT BUMP DEATH1 DEATH2 DEATH3 HURT1 HURT2 HURT3 ALIVE BEGIN DROPSHEL RELOADED MOVEUP MOVEDOWN SELECT BOING BURNER"
-LANG=C # relying on english output from dd
+LC_ALL=C # relying on english output from dd
 
 for i in $names; do
 	if [ ! -r "$inputdir"/"$i".wav ]; then

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to