Source: elog
Version: 3.1.1-1-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: environment
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that elog could not be built reproducibly.
It uses the shell-builtin 'echo' which behaves differently depending on
the used shell.

The attached patch uses printf instead, which is shell-independent.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/rules b/debian/rules
index 1613fde..dbf1db3 100755
--- a/debian/rules
+++ b/debian/rules
@@ -77,13 +77,13 @@ binary-arch: build install
 	# Remove contrib content and install new README with download location of external contributions
 	# Reason: Too many different authors with too many different licenses: Should stay external of Debian
 	mkdir -p $(DESTDIR)/$(DOCDIR)/contrib
-	echo "Download external elog contributions here: https://midas.psi.ch/elogs/Contributions/"; > $(DESTDIR)/$(DOCDIR)/contrib/README
+	printf "Download external elog contributions here: https://midas.psi.ch/elogs/Contributions/"; > $(DESTDIR)/$(DOCDIR)/contrib/README
 	dh_installchangelogs $(SRCDIR)/doc/ChangeLog
 	dh_installexamples debian/examples/*
 	dh_installman $(SRCDIR)/man/*
 	# install empty ssl directoy and skip the server.crt / server.key from orig sources
 	mkdir -p $(DESTDIR)/usr/share/elog/ssl
-	echo "In case SSL is enabled in '/etc/elog.conf' make here manually the following symbolic links:\n   ./server.key -> /etc/ssl/private/my.key\n   ./server.crt -> /etc/ssl/certs/my.pem\n\nGeneration of self-signed SSL certificates can e.g. be done easily with command /usr/sbin/make-ssl-cert from package ssl-cert." > $(DESTDIR)/usr/share/elog/ssl/README
+	printf "In case SSL is enabled in '/etc/elog.conf' make here manually the following symbolic links:\n   ./server.key -> /etc/ssl/private/my.key\n   ./server.crt -> /etc/ssl/certs/my.pem\n\nGeneration of self-signed SSL certificates can e.g. be done easily with command /usr/sbin/make-ssl-cert from package ssl-cert." > $(DESTDIR)/usr/share/elog/ssl/README
 	dh_lintian
 	# install the init script but do not modify the postinst, prerm and postrm scripts
 	dh_installinit --noscripts

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to