Source: viking
Version: 1.6-1
Severity: wishlist
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org
Control: forwarded -1 https://github.com/viking-gps/viking/pull/13

Dear Maintainer,

While working on the “reproducible builds” effort [1], we have noticed
that 'viking' could not be built reproducibly.

The attached patch fixes icon headers inclusion order. Once applied,
viking can be built reproducibly in our current experimental framework.

Regards,
Alexis Bienvenüe.

 [1]: https://wiki.debian.org/ReproducibleBuilds


diff -Nru viking-1.6/debian/patches/series viking-1.6/debian/patches/series
--- viking-1.6/debian/patches/series	2015-09-15 23:14:43.000000000 +0200
+++ viking-1.6/debian/patches/series	2016-04-10 14:10:21.000000000 +0200
@@ -2,3 +2,4 @@
 0003-Add-missing-lz.patch
 no_doc-dir.patch
 fix-IT_PROG_INTLTOOL-and-AM_GNU_GETTEXT-conflict.patch
+sort-icon-headers.patch
diff -Nru viking-1.6/debian/patches/sort-icon-headers.patch viking-1.6/debian/patches/sort-icon-headers.patch
--- viking-1.6/debian/patches/sort-icon-headers.patch	1970-01-01 01:00:00.000000000 +0100
+++ viking-1.6/debian/patches/sort-icon-headers.patch	2016-04-10 14:22:01.000000000 +0200
@@ -0,0 +1,17 @@
+Description: Sort icon headers
+ Sort icon headers to build src/cons/icons.c, to get reproducible build.
+Author: Alexis Bienvenüe <p...@passoire.fr>
+
+Index: viking-1.6/src/icons/Makefile.am
+===================================================================
+--- viking-1.6.orig/src/icons/Makefile.am
++++ viking-1.6/src/icons/Makefile.am
+@@ -267,7 +267,7 @@ icons.h: $(ALL_ICONS_HEADER)
+ icons.c: $(ALL_ICONS_HEADER)
+ 	echo "/* Generated file */" > $@
+ 	echo "#include <gdk-pixbuf/gdk-pixdata.h>" >> $@
+-	for file in *_pixmap.h ; do echo "#include \"$$file\"" >> $@ ; done
++	for file in $(ALL_ICONS_HEADER) ; do echo "#include \"$$file\"" >> $@ ; done
+ 
+ $(BUILT_SOURCES): $(srcdir)/Makefile.am
+ 
_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to