Hi intrigeri,

On Tue, May 17, 2016 at 01:16:28PM +0200, intrigeri wrote:
> The ISO build from our feature/stretch branch, that generates these
> files, has been broken for a while, and after some weeks our Jenkins
> set up deletes artifacts it considers to be obsolete… so these files
> have indeed disappeared. Sorry for the inconvenience, and thanks for
> the heads up: I didn't consciously realize that such breakage would
> impact you folks :/
> 
> I'm working on it and hope to fix it today.

ah, cool! (and don't worry, this didnt cause much inconvenience, just
some warning emails (and the tails pkg set didnt get updated)…)
 
> > https://tests.reproducible-builds.org/unstable/amd64/pkg_set_tails.html
> > https://tests.reproducible-builds.org/unstable/amd64/pkg_set_tails_build-depends.html
> Right, it's lovely that we have these, thank you! :)

:) thanks for these kind words!

> And by the way, once the above is fixed, I want to quickly switch our
> pkgset generation process from our (very hackish and inaccurate)
> .binpkgs/.srcpkgs files, to our new (accurate) .build-manifest one.
> 
> I've prepared a branch that does this switch and adjusts
> bin/reproducible_create_meta_pkg_sets.sh accordingly:

great, thanks!

>  * I used explicit argument passing to the function this branch
>    introduces, instead of global variables; if you prefer, I can of
>    course adjust this to use global variables, to match the current
>    code's style more closely, regardless of whatever my personal taste
>    in such matters is.

Actually I prefer your coding style over the one I used… I'd probably made
the tmpfile and packages variables local variables though.

>  * I really didn't want to parse YAML by hand, hence the inline Python
>    script. I've seen a Perl one in the same file already, so I've
>    assumed it would be OK. If you prefer I can certainly move that
>    function into its own, dedicated script.

hehe, I actually like those 10 lines in-line, they serve as a nice
example.

I'll gladly merge this whenever you tell me I should. Thanks again!


-- 
cheers,
        Holger

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to