Source: xgalaga++
Version: 0.8.4-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that xgalaga++ could not be built reproducibly.
The list of source files is not sorted, which leads to a
non-deterministic linking order.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible_build.patch b/debian/patches/reproducible_build.patch
new file mode 100644
index 0000000..0f7c834
--- /dev/null
+++ b/debian/patches/reproducible_build.patch
@@ -0,0 +1,14 @@
+Author: Reiner Herrmann <rei...@reiner-h.de>
+Description: Sort source files to get a deterministic linking order
+
+--- a/Makefile
++++ b/Makefile
+@@ -124,7 +124,7 @@
+ LDOPTS = $(GOAL_OPTS) $(LNK_LIBS)
+ 
+ # source files in this project
+-sources := $(wildcard $(srcdir)/*.$(SOURCE_SUFFIX))
++sources := $(sort $(wildcard $(srcdir)/*.$(SOURCE_SUFFIX)))
+ 
+ # object files in this project
+ objs := $(notdir $(sources))
diff --git a/debian/patches/series b/debian/patches/series
index 67dff1b..9112cf3 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 fix_man_section
+reproducible_build.patch

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to