Source: kraptor
Version: 0.0.20040403-9
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that kraptor could not be built reproducibly.
The list of source files is unsorted, which leads to a non-deterministic
linking order.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/15_reproducible-build.patch b/debian/patches/15_reproducible-build.patch
new file mode 100644
index 0000000..24f73e8
--- /dev/null
+++ b/debian/patches/15_reproducible-build.patch
@@ -0,0 +1,14 @@
+Author: Reiner Herrmann <rei...@reiner-h.de>
+Description: Sort source files for deterministic linking order
+
+--- a/makefile.all
++++ b/makefile.all
+@@ -1,7 +1,7 @@
+ # Makefile generic - Rules to build
+ # Fixed at last! :), thanks to Schwarzung
+ 
+-TEMP = $(wildcard $(SRCDIR)/*$(SRCSUF))
++TEMP = $(sort $(wildcard $(SRCDIR)/*$(SRCSUF)))
+ FILES = $(if $(TEMP), $(TEMP), $(error No source code found!))
+ OBJS = $(addprefix $(OBJDIR)/,$(addsuffix $(OBJSUF), $(basename $(notdir $(FILES) ) ) ) )
+ 
diff --git a/debian/patches/series b/debian/patches/series
index 4716092..f318530 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -12,3 +12,4 @@
 12_save-games-in-home.patch
 13_save-bitmaps-in-home.patch
 14_create-hidden-kraptor-directory-in-home.patch
+15_reproducible-build.patch

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to