Package: diffoscope
Version: 54
Tags: patch
Severity: wishlist

Hi,

I seem find the "No differences found inside, yet data differs" message 
misleading every time I read it.

There *are* differences found inside, as the second clause of the sentence 
confirms - what it's really trying to communicate is that there were no 
"clever" or file format specific differences found. 

Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-
diff --git a/diffoscope/comparators/binary.py b/diffoscope/comparators/binary.py
index 14c0613..9dfd44c 100644
--- a/diffoscope/comparators/binary.py
+++ b/diffoscope/comparators/binary.py
@@ -207,7 +207,7 @@ class File(object, metaclass=ABCMeta):
                     difference = self.compare_bytes(other, source=source)
                     if difference is None:
                         return None
-                    difference.add_comment("No differences found inside, yet 
data differs")
+                    difference.add_comment("No file format specific 
differences found inside, yet data differs")
             except subprocess.CalledProcessError as e:
                 difference = self.compare_bytes(other, source=source)
                 if e.output:
_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to