Your message dated Tue, 01 Nov 2016 16:19:03 +0000 with message-id <e1c1bmb-0002fs...@fasolo.debian.org> and subject line Bug#838984: fixed in diffoscope 62 has caused the Debian Bug report #838984, regarding diffoscope: tests fails in jessie-backports to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 838984: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838984 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---source: diffoscope version: 60 If the test suite is run as-is in jessie-backports it fails, and it really shouldn't. I'd like to have this fixed for v61, so I can avoid doing ugly things for backporting it like https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?h=60_bpo8%2b1&id=8b803f7a67c1c788bc442e35d8c3ddce91ead871 Following the failing tests: =============================================================================== FAILURES =============================================================================== ___________________________________________________________________________ test_differences ___________________________________________________________________________ differences = [<Difference test1.jar -- test2.jar [<Difference zipinfo -v {} -- zipinfo -v {} []>, <Difference com/example/MainActiv....class [<Difference javap -verbose -constants -s -l -private {} -- javap -verbose -constants -s -l -private {} []>]>]>] @skip_unless_tools_exist('enjarify', 'zipinfo', 'javap') def test_differences(differences): assert differences[0].source1 == 'test1.jar' assert differences[0].source2 == 'test2.jar' zipinfo = differences[0].details[0] classdiff = differences[0].details[1] assert zipinfo.source1 == 'zipinfo -v {}' assert zipinfo.source2 == 'zipinfo -v {}' assert classdiff.source1 == 'com/example/MainActivity.class' assert classdiff.source2 == 'com/example/MainActivity.class' expected_diff = open(data('dex_expected_diffs')).read() found_diff = zipinfo.unified_diff + classdiff.details[0].unified_diff > assert expected_diff == found_diff E assert '@@ -54,15 +5...args_size=1\n' == '@@ -54,15 +54...args_size=1\n' E @@ -54,15 +54,15 @@ E version of encoding software: 2.0 E minimum file system compatibility required: MS-DOS, OS/2 or NT FAT E minimum software version required to extract: 2.0 E compression method: none (stored) E file security status: not encrypted E extended local header: no E file last modified on (DOS date/time): 1980 Jan 1 00:00:00 E - 32-bit CRC value (hex): fc227a58 E + 32-bit CRC value (hex): 19c9f64e E compressed size: 305 bytes E uncompressed size: 305 bytes E length of filename: 30 characters E length of extra field: 0 bytes E length of file comment: 0 characters E disk number on which file begins: disk 1 E apparent file type: binary E @@ -17,16 +17,16 @@ E - #12 = Methodref #4.#11 // android/app/Activity.onCreate:(Landroid/os/Bundle;)V E + #12 = Methodref #4.#11 // android/app/Activity.onCreate:(Landroid/os/Bundle;)V E ? + E #13 = Integer 2130903040 E #14 = Float 1.7412887E38f E #15 = Utf8 setContentView E #16 = Utf8 (I)V E - #17 = NameAndType #15:#16 // setContentView:(I)V E + #17 = NameAndType #15:#16 // setContentView:(I)V E ? + E - #18 = Methodref #2.#17 // com/example/MainActivity.setContentView:(I)V E + #18 = Methodref #2.#17 // com/example/MainActivity.setContentView:(I)V E ? + E - #19 = Utf8 Sat Nov 21 14:20:33 CET 2015 E - - #20 = String #19 // Sat Nov 21 14:20:33 CET 2015 E + - #20 = String #19 // Sat Nov 21 14:20:33 CET 2015 E ? + E + #19 = Utf8 Thu Mar 17 11:54:42 CET 2016 E - + #20 = String #19 // Thu Mar 17 11:54:42 CET 2016 E + + #20 = String #19 // Thu Mar 17 11:54:42 CET 2016 E ? + E #21 = Utf8 Code E { E public com.example.MainActivity(); E - descriptor: ()V E + Signature: ()V E flags: ACC_PUBLIC E Code: E stack=300, locals=1, args_size=1 tests/comparators/test_dex.py:55: AssertionError ______________________________________________________________________________ test_diff _______________________________________________________________________________ differences = [<Difference javap -verbose -constants -s -l -private {} -- javap -verbose -constants -s -l -private {} []>] @skip_unless_tools_exist('javap') def test_diff(differences): expected_diff = open(data('class_expected_diff')).read() > assert differences[0].unified_diff == expected_diff E assert '@@ -36,12 +3...ne 3: 0\n }\n' == '@@ -31,13 +31..."Test.java"\n' E - @@ -36,12 +36,12 @@ E ? ^ ^ ^ ^ E + @@ -31,13 +31,13 @@ E ? ^ ^ ^ ^ E + line 1: 0 E + E public static int main(java.lang.String[]); E - Signature: ([Ljava/lang/String;)I E ? ^ ^^^ ^ - E + descriptor: ([Ljava/lang/String;)I E ? ^^^^^ ^ ^ E flags: ACC_PUBLIC, ACC_STATIC E - LineNumberTable: E - line 3: 0 E Code: E stack=1, locals=1, args_size=1 E - 0: bipush 42 E - - 2: ireturn E ? ------- E + - 2: ireturn E - + 0: iconst_m1 E ? ----- E + + 0: iconst_m1 E - + 1: ireturn E ? ------- E + + 1: ireturn E LineNumberTable: E line 3: 0 E } E + SourceFile: "Test.java" tests/comparators/test_java.py:45: AssertionError _________________________________________________________________________ test_identification __________________________________________________________________________ file1 = <<class 'diffoscope.comparators.binary.FilesystemFile'> /build/diffoscope-61/tests/data/test1.ppu> @skip_unless_tools_exist('ppudump') def test_identification(file1): > assert isinstance(file1, PpuFile) E assert isinstance(<<class 'diffoscope.comparators.binary.FilesystemFile'> /build/diffoscope-61/tests/data/test1.ppu>, PpuFile) tests/comparators/test_ppu.py:39: AssertionError ______________________________________________________________________________ test_diff _______________________________________________________________________________ differences = [] @skip_unless_tools_exist('ppudump') def test_diff(differences): > print(differences[0].unified_diff) E IndexError: list index out of range tests/comparators/test_ppu.py:51: IndexError ______________________________________________________________________ test_compare_non_existing _______________________________________________________________________ monkeypatch = <_pytest.monkeypatch.monkeypatch object at 0x7f27588b0e48> file1 = <<class 'diffoscope.comparators.binary.FilesystemFile'> /build/diffoscope-61/tests/data/test1.ppu> @skip_unless_tools_exist('ppudump') def test_compare_non_existing(monkeypatch, file1): > assert_non_existing(monkeypatch, file1, has_null_source=False) tests/comparators/test_ppu.py:57: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ monkeypatch = <_pytest.monkeypatch.monkeypatch object at 0x7f27588b0e48> fixture = <<class 'diffoscope.comparators.binary.FilesystemFile'> /build/diffoscope-61/tests/data/test1.ppu>, has_null_source = False, has_details = True def assert_non_existing(monkeypatch, fixture, has_null_source=True, has_details=True): monkeypatch.setattr(Config.general, 'new_file', True) difference = fixture.compare(NonExistingFile('/nonexisting', fixture)) output_html(difference, print_func=print) output_text(difference, print_func=print) assert difference.source2 == '/nonexisting' > assert not has_details or len(difference.details) > 0 E assert (not True or 0 > 0) E + where 0 = len([]) E + where [] = <Difference /build/diffoscope-61/tests/data/test1.ppu -- /nonexisting []>.details tests/comparators/utils.py:78: AssertionError -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---Source: diffoscope Source-Version: 62 We believe that the bug you reported is fixed in the latest version of diffoscope, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 838...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Mattia Rizzolo <mat...@debian.org> (supplier of updated diffoscope package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 01 Nov 2016 15:33:45 +0000 Source: diffoscope Binary: diffoscope trydiffoscope Architecture: source Version: 62 Distribution: unstable Urgency: medium Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org> Changed-By: Mattia Rizzolo <mat...@debian.org> Description: diffoscope - in-depth comparison of files, archives, and directories trydiffoscope - in-depth comparison of files, archives, etc. (try.diffoscope.org Closes: 838984 839538 841146 Changes: diffoscope (62) unstable; urgency=medium . [ Chris Lamb ] * progress: Pass the fileobj to the print(..) function, not str.format. Thanks to Marius Gedminas <mar...@gedmin.as>. * Move diffoscope.Config to a more-standard and simpler singleton pattern and validate constraints on every __setattr__. . [ Maria Glukhova ] * tests/{dex,java}: Skip the java tests if javap is older than 1.8. This fixes test_java and test_dex failing in jessie-backports. See #838984 . [ Michel Messerschmidt ] * comparators/zip: Add rudimentary support for OpenDocumentFormat files. . [ Mattia Rizzolo ] * debian: bump debhelper compat level to 10, no changes needed. * comparators/ppu: + don't do run a full ppudump while only looking for PPU file version. + ignore decoding errors from ppudump while filtering the output. * tests/ppu: skip some PPU tests if ppudump is < 3.0.0. Closes: #838984 * tests: skip test using a format accepted by older pytest. Closes: #841146 . [ Daniel Shahaf ] * comparators/json: detect order-only differences and print them nicely. Closes: #839538 Checksums-Sha1: 39e9ef2a8125ccc5bf4011b996f478a87c4eeb68 2864 diffoscope_62.dsc d36d4b9269fcf7c9466af6d152771602f7c7b202 313004 diffoscope_62.tar.xz Checksums-Sha256: 803d15338ad720adc73078be95afe5838abfe80d67a94c30ed9527499ee86d63 2864 diffoscope_62.dsc 30e364b4c2cba160be9ed0e1716f0ceb7490e2d140050e89eac00c42ce374f2d 313004 diffoscope_62.tar.xz Files: 0d87b7a85f9bfc0bb30606570dc5ddae 2864 devel optional diffoscope_62.dsc 82470149594e108e1d14052af04e1e88 313004 devel optional diffoscope_62.tar.xz -----BEGIN PGP SIGNATURE----- iQIvBAEBCgAZBQJYGLu6EhxtYXR0aWFAZGViaWFuLm9yZwAKCRAIFrnhjHYrrdx4 EACBRNv2AUlpKzFWgJ0mDjL2Qdi/PO8MXvgRlYPaPlTGpLZ5u2hHx1PcScUExdwR z5CF63JrEoGz0eWBHy3nj9dkSyA50G/SedVJzrsi2ytPu+O8Sn8i81DcnHAFOVhH wFW2BkMhkM1ITvK8pWwEgfqDATG6yDUg6mg+d0l3qF/RxewmDHtNy4XRyE286Y3J Gr3pF9Ov4kt6KHjzUeop6KAhauS2zvDhULGcIXXWmdCNi3CbJSJR4n3u9nLIjcIi kwUxT48pssrR03baka1F69we1zloqu5JB5n6HfUKQ7pJIl3KcjpvFi0uPbYfUhpo aO23l8y3VgY7/CMP8/B+DCGvlaT3Yap6giIpCDDpdeTc4dqLhYLGryGvvSLefVh7 OlEUA5wH37DkbvbEP0EKYcRpoW12Mtk4HFoP9gQcQweHg3cwBg7JiwKfQ8IslkVY +azqsHONkk414pMe3vQ5EotoG8v3Vedmkd0obSULSWA8+1LuEf2MSfnaINCYQse2 kBvkFylrq/zuoE7vzlXVbZ3XEA9zqf3GzfiLsL5ugrdxYOGFuBJFpTVGu8Baqs15 h35Xgjqil8K3hHfq1Eyq+bYF5M5KLfySMgNgYOD5b0Pb3xYr1zXlcsmbRxz9SIzI T1MSsPHagt1Ej+0a4XlTMomEr9oicNopfSW4CJO3Dp5HkQ== =nYbu -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
