Your message dated Wed, 08 Feb 2017 00:33:28 +0000
with message-id <[email protected]>
and subject line Bug#835641: fixed in diffoscope 71
has caused the Debian Bug report #835641,
regarding diffoscope: tracebacks when comparing directories to non-directories
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
835641: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=835641
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: diffoscope
Version: 59
Severity: normal

$ mkdir dir

$ ln -sf dst-file src-file

$ diffoscope dir src-file
cmp: dir: Is a directory
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 200, in main
    sys.exit(run_diffoscope(parsed_args))
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 171, in 
run_diffoscope
    parsed_args.path1, parsed_args.path2)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/__init__.py", 
line 102, in compare_root_paths
    return compare_files(file1, file2)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/__init__.py", 
line 117, in compare_files
    return file1.compare_bytes(file2, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/binary.py", line 
170, in compare_bytes
    return compare_binary_files(self, other, source)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/binary.py", line 
55, in compare_binary_files
    return Difference.from_command(diffoscope.comparators.utils.Xxd, 
file1.path, file2.path, source=[file1.name, file2.name])
  File "/usr/lib/python3/dist-packages/diffoscope/difference.py", line 356, in 
from_command
    difference = Difference.from_feeder(feeder1, feeder2, path1, path2, *args, 
**kwargs)
  File "/usr/lib/python3/dist-packages/diffoscope/difference.py", line 306, in 
from_feeder
    unified_diff = diff(feeder1, feeder2)
  File "/usr/lib/python3/dist-packages/diffoscope/difference.py", line 270, in 
diff
    return run_diff(fd1, fd2, end_nl_q1, end_nl_q2)
  File "/usr/lib/python3.5/contextlib.py", line 66, in __exit__
    next(self.gen)
  File "/usr/lib/python3/dist-packages/diffoscope/difference.py", line 205, in 
fd_from_feeder
    t.join()
  File "/usr/lib/python3/dist-packages/diffoscope/difference.py", line 183, in 
join
    raise ex
  File "/usr/lib/python3/dist-packages/diffoscope/difference.py", line 169, in 
run
    super().run(*args, **kwargs)
  File "/usr/lib/python3.5/threading.py", line 862, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib/python3/dist-packages/diffoscope/difference.py", line 190, in 
feed
    end_nl = feeder(f)
  File "/usr/lib/python3/dist-packages/diffoscope/difference.py", line 260, in 
feeder
    raise subprocess.CalledProcessError(returncode, command.cmdline(), 
output=command.stderr.getvalue())
subprocess.CalledProcessError: Command '['xxd', 'dir']' returned non-zero exit 
status 2
Exception ignored in: <bound method File.__del__ of <<class 'abc.Symlink'> 
src-file>>
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/binary.py", line 
112, in __del__
    self.cleanup()
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/symlink.py", line 
50, in cleanup
    os.remove(self._placeholder)
FileNotFoundError: [Errno 2] No such file or directory: 
'/tmp/tmpzvwrnvg4_diffoscope'

q(Tried writing a test but couldn't seem to reproduce there…)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      [email protected] / chris-lamb.co.uk
       `-

--- End Message ---
--- Begin Message ---
Source: diffoscope
Source-Version: 71

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <[email protected]> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 08 Feb 2017 13:02:01 +1300
Source: diffoscope
Binary: diffoscope
Architecture: source
Version: 71
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks 
<[email protected]>
Changed-By: Chris Lamb <[email protected]>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 820427 835641 850791 851147 852013 852926
Changes:
 diffoscope (71) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * New features:
     - Add a machine-readable JSON output format. (Closes: #850791)
     - Show results from debugging packages last. (Closes: #820427)
     - Add a --max-text-report-size option. (Closes: #851147)
   * Bug fixes:
     - Clean all temp files in signal handler thread instead of attempting to
       bubble exception back to the main thread. (Closes: #852013)
     - Prevent FTBFS by loading fixtures as UTF-8 in case surrounding terminal
       is not Unicode-aware. (Closes: #852926)
     - Fix errors when comparing directories with non-directories.
       (Closes: #835641)
     - Fix behaviour of setting report maximums to zero (ie. no limits)
   * Tests:
     - Test the RPM "fallback" comparison.
     - Test the Deb{Changes,Buildinfo,Dsc} fallback comparisons.
     - Test --progress and --status-fd output.
     - Add tests for symlinks differing in destination.
     - When comparing two empty directories, ensure that the mtime of the
       directory is consistent to avoid non-deterministic failures.
     - Smoke test profiling output.
     - Ensure we ignore invalid JSON files correctly.
     - Ensure 2nd source of a Difference is a string, not just the 1st.
     - Don't report on test coverage for some internal error messages.
   * Misc:
     - Add docs about releasing signed tarballs.
     - Drop the incomplete list of external tools from README.rst.
     - Add debian/watch file with cryptographic signature verification.
     - Drop CpioContent command now that we use libarchive.
     - Use a singleton to manage our Comparator classes.
     - Many small optimisations and code cleanups.
 .
   [ Brett Smith ]
   * diffoscope.diff: Improve FIFO writing robustness.
 .
   [ Ximin Luo ]
   * Fix bug introduced in commit 36d1c964 that only worked "accidentally".
   * Fix lazy expression; filter is lazy in Python 3.
 .
   [ Mattia Rizzolo ]
   * Override the debian-watch-file-in-native-package lintian tag.
 .
   [ anthraxx ]
   * Arch package changed from cdrkit to cdrtools.
 .
   [ Holger Levsen ]
   * Restore history section in README, explaining this was started in Debian.
Checksums-Sha1:
 1832433b5abac42db836eff287c5793eaa70f9bb 2972 diffoscope_71.dsc
 d920b5ba95f822a797be1c1245b934c18ac0f4dd 339944 diffoscope_71.tar.xz
 b4c699f01bdfb533d8f707606fbe96ab2656a25a 16031 diffoscope_71_amd64.buildinfo
Checksums-Sha256:
 a2035d715cfb0e2a9efdc7a359eb21391ee9ba73b9dd89410f256843fb37d772 2972 
diffoscope_71.dsc
 e4b0f6d1fcfde562b1ebe91755a9dad44eea6c48f411f9ec6d563fdb31f7e37d 339944 
diffoscope_71.tar.xz
 087b7e96278887fcca56d211d35e113c4ab64dbc4c94b308afdcd1d2f075ba7a 16031 
diffoscope_71_amd64.buildinfo
Files:
 c699f92bd9f4465f8332527d9c5596bd 2972 devel optional diffoscope_71.dsc
 9825476e43ad267e8f1453483247e5a7 339944 devel optional diffoscope_71.tar.xz
 e20405b66c13bb0200f7dabb8c8ae2c5 16031 devel optional 
diffoscope_71_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAliaYcsACgkQHpU+J9Qx
HljBpg/+LSuKfoTDoN52dFGG9r977qYkem4Il8Eu3A7TOn8z7hn+WG4yrEPCwRSZ
SR9/5pSY4ykWP2z2gNqD06rq+AQ3avu/rAl3aknn91SUB9TZ3T+6/rkTVxa8oMHw
fut9rj7jH8jRsnA3rp50gz4hti8pKK8NROnnd3tOPfT1jeU1m46pg7nUOtFOHmEP
BjUa3ThP0U3xyWkOTGKk90+TLER8TPqAaA/2/dMoqbF2rvO865z7FVt2SZ1+cLYB
U2X7GYVrldp5VsYsyT7kyVAZUhNqopdzVhM8juwpPFrYPvyTnIV9xjOEV/N6SMve
e7XrvUx5n94t8cJQk2SVQ1XKSYJvP9TpadfygIN1wbtNEDVw98RYTlROGLO6T0sK
U5Wezh8erTVZtdMoCw2IszgMiXoejI0ogO5hUA+OSeLr1HBl3c55ae5Ij7ugVKWV
B+4qX8KEV5LeF83I7UuurMq1WZoVJ9YldIQqhNE3d7dDcwRaxAJrGAsiAIv5bRJ9
N8NlcOGW+HJJ6+vSAPg32zxv87FQTeVPQYakdYEaMmSWiX+tmVMuQF45g/8iGe3y
82bTneLbzSCUeZQKdAzKN/sHqHOh47mxCmYZYWp2jYBj+FfJ/04l0884jECEtoL5
8g7DLPMd+EIbFZL+5A9WNIyD9OWUdKHLBzx4y77o5ZfQrlYhgkM=
=Ffbm
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Reproducible-builds mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to