Hi Chris,
On 21.04.2017 22:58, Chris Lamb wrote: > Hey Maria, Thank you for looking into this! > Some very quick thoughts: > [...] I tried to improve indentation and other cosmetic things. What do you think of the current state? Regarding Config().html_output -- I put the comment that should (hopefully) clarify the meaning of it, but I'm afraid I haven't found a convenient way to avoid making it global. The point of including it was to skip computation on the comparison level of anything we're not going to use later on the presenter level. Another way to achieve this behavior would be to make visual differences lazy, actually constructing images only when we're about to print them. But that also appears to be an abstraction-layer violation (I'm not even sure temporary files, e.g. from archive unpacking, are still present at this point...). I would greatly appreciate your ideas on this issue, as I seem to lack the experience to resolve it in a more elegant manner :) Thanks again for sharing your thoughts on this. Regards, Maria _______________________________________________ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds