Your message dated Tue, 11 Jul 2017 19:06:34 +0000
with message-id <e1dv0uu-000dfh...@fasolo.debian.org>
and subject line Bug#868064: fixed in strip-nondeterminism 0.036-1
has caused the Debian Bug report #868064,
regarding dh-strip-nondeterminism: Emits noisy warning when tmpdir() is not
created
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
868064: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868064
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: dh-strip-nondeterminism
Version: 0.035-2
Severity: minor
Tags: patch upstream
Hi,
When dh_strip_nondeterminism is called, it will emit a noisy warning
about the tmpdir not existing when this is the case while still
exiting with 0 after said warning. Example:
"""
$ dh_strip_nondeterminism
Can't stat debian/goodbye-dh: No such file or directory
at /usr/bin/dh_strip_nondeterminism line 71.
$ echo $?
0
"""
Attached patch avoids said warning. This may become more relevant due
to the following debhelper compat 11 change:
"""
* dh_auto_install will now only create the destination directory it
needs. Previously, it would create the package build directory for
all packages. This will not affect packages that only build with
debhelper commands, but it may expose bugs in commands not
included in debhelper.
"""
Thanks,
~Niels
>From 2140384edf4831d45e2d4f1d1a0d83530f220d75 Mon Sep 17 00:00:00 2001
From: Niels Thykier <ni...@thykier.net>
Date: Tue, 11 Jul 2017 17:58:35 +0000
Subject: [PATCH] dh_strip_nd: Assumes tmpdir() exists
Signed-off-by: Niels Thykier <ni...@thykier.net>
---
bin/dh_strip_nondeterminism | 2 ++
1 file changed, 2 insertions(+)
diff --git a/bin/dh_strip_nondeterminism b/bin/dh_strip_nondeterminism
index c8bb662..a363be1 100755
--- a/bin/dh_strip_nondeterminism
+++ b/bin/dh_strip_nondeterminism
@@ -67,6 +67,8 @@ File::StripNondeterminism::init();
foreach my $package (@{$dh{DOPACKAGES}}) {
my $tmp=tmpdir($package);
+ next if not -d $tmp;
+
@nondeterministic_files=();
find(\&testfile,$tmp);
next unless @nondeterministic_files;
--
2.13.2
--- End Message ---
--- Begin Message ---
Source: strip-nondeterminism
Source-Version: 0.036-1
We believe that the bug you reported is fixed in the latest version of
strip-nondeterminism, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 868...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Lamb <la...@debian.org> (supplier of updated strip-nondeterminism package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 11 Jul 2017 19:41:39 +0100
Source: strip-nondeterminism
Binary: libfile-stripnondeterminism-perl strip-nondeterminism
dh-strip-nondeterminism
Architecture: source
Version: 0.036-1
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks
<reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <la...@debian.org>
Description:
dh-strip-nondeterminism - file non-deterministic information stripper —
Debhelper add-on
libfile-stripnondeterminism-perl - file non-deterministic information stripper
— Perl module
strip-nondeterminism - file non-deterministic information stripper —
stand-alone tool
Closes: 867982 868064
Changes:
strip-nondeterminism (0.036-1) unstable; urgency=medium
.
[ Niels Thykier ]
* File::StripNondeterminism:
+ Optimize load times of File::StripNondeterminism.
dh_strip-nondeterminism was accounting for ~4.5% of the total runtime
for a (mostly) no-op dh package build. This cost applied even to
packages for which dh_strip-nondeterminism did not normalise any files.
(Closes: #867982)
+ Apply perltidy.
* dh_strip_nondeterminism: Don't assume tmpdir() exists. This will become
more relevant for Debhelper compat level 11's `dh_auto_install` which will
only create destination directories it needs. (Closes: #868064)
Checksums-Sha1:
10e9c83a7f4102f3c1d973d5410a948464ed71b2 2526 strip-nondeterminism_0.036-1.dsc
0d046099e4c766a491a5b19f00ca2f1953e3cbb0 170779
strip-nondeterminism_0.036.orig.tar.gz
67e40d7236db74ce59aea67c37262763c52ba9c4 11760
strip-nondeterminism_0.036-1.debian.tar.xz
52d1b963acf9c8d4fc1420f4ec8e108eaf7d85da 6446
strip-nondeterminism_0.036-1_amd64.buildinfo
Checksums-Sha256:
ca16a5851b13719ecfe1918a3bd59601719b809d01adbf7f591f3f86e95d1cc7 2526
strip-nondeterminism_0.036-1.dsc
cbc28046eb825de4139467ceb09921f7f065b23d626743702852846ad3e4200d 170779
strip-nondeterminism_0.036.orig.tar.gz
0d8f4e940c4c9a4be8e7e201af82db5d277f304d60e09a2377e3f48b933b160f 11760
strip-nondeterminism_0.036-1.debian.tar.xz
44af0432c8cd20eb69cbe04a3b2fb4aac45c83bacbba7a080f898f33b1443459 6446
strip-nondeterminism_0.036-1_amd64.buildinfo
Files:
243878be6b338d014e5048942579a6bd 2526 devel optional
strip-nondeterminism_0.036-1.dsc
19e828ca48bb657dcee003295053976a 170779 devel optional
strip-nondeterminism_0.036.orig.tar.gz
539dc0736479c649abf59f438d0543d6 11760 devel optional
strip-nondeterminism_0.036-1.debian.tar.xz
1266e5f960cfb8dad508ba40702888a2 6446 devel optional
strip-nondeterminism_0.036-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlllHC0ACgkQHpU+J9Qx
HljrcRAAso5OjS8u6x117P2EGEVerXb0YI0JcmjatMvIGc18jB23Gt7Nfzgcoj4q
aI+1QIWpa+4c92qeEhF42FdEDg8bJkkFdPK6RsdZ2MGHoberlQW/BID+2Ssqf86t
fSVu4kNbESN0VYH4dwWpajtcuiQSj0fjJQ0IJ7arXUtXPpWbiaFuuSZHbyJUNyWw
qg6dt5W5B3hk4Xx+SOpGLdeXPTc0HGJlzbZWMVEvXnmRdGxcdDpF9TsR9SY6bFQR
ylCV/mg0soXS/zpwdeXTfXZ089k0rvVIWgSXuhH1i6FycJbwyA4DuKsSsR1EY/8h
nucA5OXx5kZ5tC5wN8IM6cReMiSLsW6pOPWcCxWE195zWOW4aO0XjC8Pe+LfNHFh
c8+g9bk/V3SKOKFNW2NX5Il24cC5aiqyL66mhvq8HFqXrBUmDWfcwqcB9thu8y9O
MubhdozzvZhSHqDI4/YjASAkb5sxP36VeBKCytbFhzD4tB1nA4E7zVyGKKgdoktp
LpAbdw5gyg4/e8s9YbHpEk9rOJT+ZjvTdz0mVtlipAn1ZAQjUin631AO41HMpXi8
P56XZ5yplcsrZeNkvjNEjCfHHS2EgYQl1Fq800enbX/CXwUfw7GKJvHO7ii13QTS
YhjxyogTpWC8l8H7reAonVD5XMTkm5A54fLeGi2CNcVOljHOJ1o=
=JD/z
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
